diff options
| author | bors <bors@rust-lang.org> | 2013-10-25 10:36:09 -0700 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2013-10-25 10:36:09 -0700 |
| commit | baeed886aa64943ad48121cc3b57dabec12bc835 (patch) | |
| tree | 28ba7cc4b0c36636e884dd6c45fcd612b25e2b37 /src/rustllvm/RustWrapper.cpp | |
| parent | deeca5d586bfaa4aa60246f671a8d611d38f6248 (diff) | |
| parent | e8f72c38f4bf74e7291043917fdd0bae1404b407 (diff) | |
| download | rust-baeed886aa64943ad48121cc3b57dabec12bc835.tar.gz rust-baeed886aa64943ad48121cc3b57dabec12bc835.zip | |
auto merge of #10060 : alexcrichton/rust/cached-stdout, r=brson
Almost all languages provide some form of buffering of the stdout stream, and this commit adds this feature for rust. A handle to stdout is lazily initialized in the Task structure as a buffered owned Writer trait object. The buffer behavior depends on where stdout is directed to. Like C, this line-buffers the stream when the output goes to a terminal (flushes on newlines), and also like C this uses a fixed-size buffer when output is not directed at a terminal. We may decide the fixed-size buffering is overkill, but it certainly does reduce write syscall counts when piping output elsewhere. This is a *huge* benefit to any code using logging macros or the printing macros. Formatting emits calls to `write` very frequently, and to have each of them backed by a write syscall was very expensive. In a local benchmark of printing 10000 lines of "what" to stdout, I got the following timings: when | terminal | redirected ----------|---------------|-------- before | 0.575s | 0.525s after | 0.197s | 0.013s C | 0.019s | 0.004s I can also confirm that we're buffering the output appropriately in both situtations. We're still far slower than C, but I believe much of that has to do with the "homing" that all tasks due, we're still performing an order of magnitude more write syscalls than C does.
Diffstat (limited to 'src/rustllvm/RustWrapper.cpp')
0 files changed, 0 insertions, 0 deletions
