about summary refs log tree commit diff
path: root/src/rustllvm/RustWrapper.cpp
diff options
context:
space:
mode:
authorkennytm <kennytm@gmail.com>2018-01-18 01:57:16 +0800
committerGitHub <noreply@github.com>2018-01-18 01:57:16 +0800
commitbd8aa02ff4b76a6aa9c03ad8ab80aaab21080e9c (patch)
treeb2988ced186bb5dd1c5bf5118c2b6e7b959964fe /src/rustllvm/RustWrapper.cpp
parente7087f0f4f5300734f37498d4ed9059aafdfcf0a (diff)
parentefe3d69ad827cc359b1a120b0e5c58dd87a2935b (diff)
downloadrust-bd8aa02ff4b76a6aa9c03ad8ab80aaab21080e9c.tar.gz
rust-bd8aa02ff4b76a6aa9c03ad8ab80aaab21080e9c.zip
Rollup merge of #47407 - gaurikholkar:master, r=estebank
fix mispositioned span

This fixes #47377

The output now looks like this
```
error[E0369]: binary operation `+` cannot be applied to type `&str`
 --> h.rs:3:11
  |
3 |     let _a = b + ", World!";
  |              ^^^^^^^^^^^^^^ `+` can't be used to concatenate two `&str` strings
help: `to_owned()` can be used to create an owned `String` from a string reference. String concatenation appends the string on the right to the string on the left and may require reallocation. This requires ownership of the string on the left
  |
3 |     let _a = b.to_owned() + ", World!";
  |              ^^^^^^^^^

error: aborting due to previous error
```
For the case when emojis are involved,  it gives the new output for proper indentation.
But for an indentation as follows,
```
fn main() {
let b = "hello";
    let _a = b + ", World!";
}
```
it still mispositions the span
```
3 |     println!("🦀🦀🦀🦀🦀"); let _a = b + ", World!";
  |                                           ^^^^^^^^^^^^^^ `+` can't be used to concatenate two `&str` strings
  |
3 |     println!("🦀🦀🦀🦀🦀"); let _a = b.to_owned() + ", World!";
  |                                           ^^^^^^^
error: aborting due to previous erro
```

cc @estebank  @est31
Diffstat (limited to 'src/rustllvm/RustWrapper.cpp')
0 files changed, 0 insertions, 0 deletions