about summary refs log tree commit diff
path: root/src/rustllvm/RustWrapper.cpp
diff options
context:
space:
mode:
authorAlex Crichton <alex@alexcrichton.com>2017-03-10 16:51:16 -0600
committerAlex Crichton <alex@alexcrichton.com>2017-03-10 16:18:25 -0800
commitda994cdee52e99c4f159b673d616158f44fc723b (patch)
tree1e9bc561832f20135c86442514dfeb60d271120f /src/rustllvm/RustWrapper.cpp
parentb92073dd521515a902c6354ad94f0adf4cf5c8a5 (diff)
parent8a64cf7fb72ca93608be19e13dd83c23168b17d7 (diff)
downloadrust-da994cdee52e99c4f159b673d616158f44fc723b.tar.gz
rust-da994cdee52e99c4f159b673d616158f44fc723b.zip
Rollup merge of #40092 - sinkuu:fix_suggestion_index, r=pnkfelix
Fix suggestion span error with a line containing multibyte characters

This PR fixes broken suggestions caused by multibyte characters.

e.g. for this code, rustc provides a broken suggestion ([playground](https://is.gd/DWGLu7)):

```rust
fn main() {
    let tup = (1,);
    println!("☃{}", tup[0]);
}
```

```
error: cannot index a value of type `({integer},)`
 --> <anon>:3:21
  |
3 |     println!("☃{}", tup[0]);
  |                     ^^^^^^
  |
help: to access tuple elements, use tuple indexing syntax as shown
  |     println!("☃{}"tup.00]);

error: aborting due to previous error
```

`CodeSuggestion::splice_lines` is misusing `Loc.col` (`CharPos`) as a byte offset when slicing source.
Diffstat (limited to 'src/rustllvm/RustWrapper.cpp')
0 files changed, 0 insertions, 0 deletions