diff options
| author | Philip Craig <philipjcraig@gmail.com> | 2019-03-23 17:00:04 +1000 |
|---|---|---|
| committer | Philip Craig <philipjcraig@gmail.com> | 2019-03-23 17:13:58 +1000 |
| commit | e8de4c3b1f0ab51fe3ea0a494cf9727ee3e0bf1d (patch) | |
| tree | c9b2d4d2a1b8012e37c9092919d8a091af9bdffa /src/rustllvm/RustWrapper.cpp | |
| parent | c82834e2b930619d4143e4dd94fb80888fa190c9 (diff) | |
| download | rust-e8de4c3b1f0ab51fe3ea0a494cf9727ee3e0bf1d.tar.gz rust-e8de4c3b1f0ab51fe3ea0a494cf9727ee3e0bf1d.zip | |
Fix invalid DWARF for enums when using thinlto
We were setting the same identifier for both the DW_TAG_structure_type and the DW_TAG_variant_part. This becomes a problem when using thinlto becauses it uses the identifier as a key for a map of types that is used to delete duplicates based on the ODR, so one of them is deleted as a duplicate, resulting in invalid DWARF. The DW_TAG_variant_part isn't a standalone type, so it doesn't need an identifier. Fix by omitting its identifier.
Diffstat (limited to 'src/rustllvm/RustWrapper.cpp')
| -rw-r--r-- | src/rustllvm/RustWrapper.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/rustllvm/RustWrapper.cpp b/src/rustllvm/RustWrapper.cpp index a00417a3629..470cdcdd613 100644 --- a/src/rustllvm/RustWrapper.cpp +++ b/src/rustllvm/RustWrapper.cpp @@ -723,12 +723,12 @@ extern "C" LLVMMetadataRef LLVMRustDIBuilderCreateVariantPart( LLVMRustDIBuilderRef Builder, LLVMMetadataRef Scope, const char *Name, LLVMMetadataRef File, unsigned LineNumber, uint64_t SizeInBits, uint32_t AlignInBits, LLVMRustDIFlags Flags, LLVMMetadataRef Discriminator, - LLVMMetadataRef Elements, const char *UniqueId) { + LLVMMetadataRef Elements) { #if LLVM_VERSION_GE(7, 0) return wrap(Builder->createVariantPart( unwrapDI<DIDescriptor>(Scope), Name, unwrapDI<DIFile>(File), LineNumber, SizeInBits, AlignInBits, fromRust(Flags), unwrapDI<DIDerivedType>(Discriminator), - DINodeArray(unwrapDI<MDTuple>(Elements)), UniqueId)); + DINodeArray(unwrapDI<MDTuple>(Elements)))); #else abort(); #endif |
