diff options
| author | Mazdak Farrokhzad <twingoow@gmail.com> | 2019-11-23 02:22:47 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-11-23 02:22:47 +0100 |
| commit | e94f066b02623bf15a4293467d0761e23c2087c4 (patch) | |
| tree | cd67be2fca503977f01450b757341e698a3b1136 /src/rustllvm/RustWrapper.cpp | |
| parent | 8256e735cf42892639d343fe85dea97c9ac9d1a9 (diff) | |
| parent | 9b40e0bb9af6641a23586fd5999430e4c7622636 (diff) | |
| download | rust-e94f066b02623bf15a4293467d0761e23c2087c4.tar.gz rust-e94f066b02623bf15a4293467d0761e23c2087c4.zip | |
Rollup merge of #66576 - pnkfelix:more-robust-gdb-vec-printer, r=alexcrichton
made gdb pretty-printing more robust when printing uninitialized vec made gdb pretty-printing more robust when printing uninitialized vec I based this solution on my reading of: https://rethinkdb.com/blog/make-debugging-easier-with-custom-pretty-printers#what-is-still-to-be-done That post claims that there is no clean way to check for garbage pointers, and so this PR adopts the same solution of tentatively attempting to convert a dererence to a string, which throws a clean exception on garbage that we can catch and recover from. I only made the change to vec and not the other pretty printers because I wanted to focus my effort on the simplest thing that would resolve issue #64343. In particular, I *considered* generalizing this fix to work on the other datatypes in the pretty-printing support library, but I don't want to invest effort in that until after we resolve our overall debugging support strategy; see also issues #60826 and #65564. Fix #64343
Diffstat (limited to 'src/rustllvm/RustWrapper.cpp')
0 files changed, 0 insertions, 0 deletions
