diff options
| author | bors <bors@rust-lang.org> | 2016-12-04 23:36:50 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2016-12-04 23:36:50 +0000 |
| commit | ebeee0e27e32e212979d9f38d285b1dc2816cd0a (patch) | |
| tree | d3a34a0d35e9ea67196fb8e946c77f78bcc81a48 /src/rustllvm/RustWrapper.cpp | |
| parent | 341f084d8d91d4a186f3aea20e31aadc95c8edf6 (diff) | |
| parent | ff1ba6a5052a3d995c31a2266e0b9cd6b1d44c1e (diff) | |
| download | rust-ebeee0e27e32e212979d9f38d285b1dc2816cd0a.tar.gz rust-ebeee0e27e32e212979d9f38d285b1dc2816cd0a.zip | |
Auto merge of #38092 - pnkfelix:mir-stats, r=nikomatsakis
Adds `-Z mir-stats`, which is similar to `-Z hir-stats`.
Adds `-Z mir-stats`, which is similar to `-Z hir-stats`.
Some notes:
* This code attempts to present the breakdown of each variant for
every enum in the MIR. This is meant to guide decisions about how to
revise representations e.g. when to box payloads for rare variants
to shrink the size of the enum overall.
* I left out the "Total:" line that hir-stats presents, because this
implementation uses the MIR Visitor infrastructure, and the memory
usage of structures directly embedded in other structures (e.g. the
`func: Operand` in a `TerminatorKind:Call`) is not distinguished
from similar structures allocated in a `Vec` (e.g. the `args:
Vec<Operand>` in a `TerminatorKind::Call`). This means that a naive
summation of all the accumulated sizes is misleading, because it
will double-count the contribution of the `Operand` of the `func` as
well as the size of the whole `TerminatorKind`.
* I did consider abandoning the MIR Visitor and instead hand-coding
a traversal that distinguished embedded storage from indirect
storage. But such code would be fragile; better to just require
people to take care when interpreting the presented results.
* This traverses the `mir.promoted` rvalues to capture stats for MIR
stored there, even though the MIR visitor super_mir method does not
do so. (I did not observe any promoted mir being newly traversed when
compiling the rustc crate, however.)
* It might be nice to try to unify this code with hir-stats. Then
again, the reporting portion is the only common code (I think), and
it is small compared to the visitors in hir-stats and mir-stats.
Diffstat (limited to 'src/rustllvm/RustWrapper.cpp')
0 files changed, 0 insertions, 0 deletions
