about summary refs log tree commit diff
path: root/src/rustllvm/RustWrapper.cpp
diff options
context:
space:
mode:
authorZack M. Davis <code@zackmdavis.net>2018-10-12 00:21:21 -0700
committerZack M. Davis <code@zackmdavis.net>2018-10-27 12:31:20 -0700
commitf90de1110d93ea389342220caad19e05c4e6ad10 (patch)
tree7508a7b5f49ace9233668d9c027dacd968b8952d /src/rustllvm/RustWrapper.cpp
parentdc0609c2473c01f521c5a3b9959edf7dd11f2d86 (diff)
downloadrust-f90de1110d93ea389342220caad19e05c4e6ad10.tar.gz
rust-f90de1110d93ea389342220caad19e05c4e6ad10.zip
in which lint reasons are restricted to come last in the attribute
Vadim Petrochenkov suggested this in review ("an error? just to be
conservative"), and it turns out to be convenient from the
implementer's perspective: in the initial proposed implementation (or
`HEAD~2`, as some might prefer to call it), we were doing an entire
whole iteration over the meta items just to find the reason (before
iterating over them to set the actual lint levels). This way, we can
just peek at the end rather than adding that extra loop (or
restructuring the existing code). The RFC doesn't seem to take a
position on this, and there's some precedent for restricting things to
be at the end of a sequence (we only allow `..` at the end of a struct
pattern, even if it would be possible to let it appear anywhere in the
sequence).
Diffstat (limited to 'src/rustllvm/RustWrapper.cpp')
0 files changed, 0 insertions, 0 deletions