diff options
| author | bors <bors@rust-lang.org> | 2021-08-11 01:36:23 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2021-08-11 01:36:23 +0000 |
| commit | 47b41b7788a6f85c749049062f1e4eed497cd894 (patch) | |
| tree | f68a519116440d8e4194981cdbacdaab12f9abf1 /src/test/codegen/align-enum.rs | |
| parent | e8e1b32a7840c07f30c04b252c379a044a73902d (diff) | |
| parent | 02295f464aaf78ece81a80e5b99a034119e74748 (diff) | |
| download | rust-47b41b7788a6f85c749049062f1e4eed497cd894.tar.gz rust-47b41b7788a6f85c749049062f1e4eed497cd894.zip | |
Auto merge of #87254 - rusticstuff:rustc_codegen_llvm_dont_emit_zero_sized_padding, r=eddyb
LLVM codegen: Don't emit zero-sized padding for fields Currently padding is emitted before fields of a struct and at the end of the struct regardless of the ABI. Even if no padding is required zero-sized padding fields are emitted. This is not useful and - more importantly - it make it impossible to generate the exact vector types that LLVM expects for certain ARM SIMD intrinsics. This change should unblock the implementation of many ARM intrinsics using the `unadjusted` ABI, see https://github.com/rust-lang/stdarch/issues/1143#issuecomment-827404092. This is a proof of concept only because the field lookup now takes O(number of fields) time compared to O(1) before since it recalculates the mapping at every lookup. I would like to find out how big the performance impact actually is before implementing caching or restricting this behavior to the `unadjusted` ABI. cc `@SparrowLii` `@bjorn3` ([Discussion on internals](https://internals.rust-lang.org/t/feature-request-add-a-way-in-rustc-for-generating-struct-type-llvm-ir-without-paddings/15007))
Diffstat (limited to 'src/test/codegen/align-enum.rs')
| -rw-r--r-- | src/test/codegen/align-enum.rs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/test/codegen/align-enum.rs b/src/test/codegen/align-enum.rs index 0f2cf5a7616..441cd04690e 100644 --- a/src/test/codegen/align-enum.rs +++ b/src/test/codegen/align-enum.rs @@ -8,7 +8,7 @@ pub enum Align64 { A(u32), B(u32), } -// CHECK: %Align64 = type { [0 x i32], i32, [15 x i32] } +// CHECK: %Align64 = type { i32, [15 x i32] } pub struct Nested64 { a: u8, |
