about summary refs log tree commit diff
path: root/src/test/codegen/src-hash-algorithm/src-hash-algorithm-sha1.rs
diff options
context:
space:
mode:
authorYuki Okushi <huyuumi.dev@gmail.com>2021-01-28 15:09:00 +0900
committerGitHub <noreply@github.com>2021-01-28 15:09:00 +0900
commit025a850d217053f538b8638dec3696e9622d3edb (patch)
tree9b2233a2a5e7e2c862ae7d4a0ad548b0c4a71bd9 /src/test/codegen/src-hash-algorithm/src-hash-algorithm-sha1.rs
parente32f372c4203b2527221b313cf63b05ea178e8a9 (diff)
parent8a18fb0f7396ceb1ca18cd82ca3deb795f5e60b2 (diff)
downloadrust-025a850d217053f538b8638dec3696e9622d3edb.tar.gz
rust-025a850d217053f538b8638dec3696e9622d3edb.zip
Rollup merge of #70904 - LukasKalbertodt:stabilize-seek-convenience, r=m-ou-se
Stabilize `Seek::stream_position` (feature `seek_convenience`)

Tracking issue: #59359

Unresolved questions from tracking issue:
- "Override `stream_len` for `File`?" → we can do that in the future, this does not block stabilization.
- "Rename to `len` and `position`?" → as noted in the tracking issue, both of these shorter names have problems (`len` is usually a cheap getter, `position` clashes with `Cursor`). I do think the current names are perfectly fine.
- "Rename `stream_position` to `tell`?" → as mentioned in [the comment bringing this up](https://github.com/rust-lang/rust/issues/59359#issuecomment-559541545), `stream_position` is more descriptive. I don't think `tell` would be a good name.

What remains to decide, is whether or not adding these methods is worth it.
Diffstat (limited to 'src/test/codegen/src-hash-algorithm/src-hash-algorithm-sha1.rs')
0 files changed, 0 insertions, 0 deletions