diff options
| author | Dylan DPC <dylan.dpc@gmail.com> | 2020-10-07 00:16:01 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-10-07 00:16:01 +0200 |
| commit | 59707c57488eac0766a2e28525a70d6801edf1a7 (patch) | |
| tree | b576842f75f5e2c75d04d6cff85aa58dfd5881ff /src/test/codegen/src-hash-algorithm/src-hash-algorithm-sha256.rs | |
| parent | 5ae45ea4e29e2e381ca2ced503a7aac3262f24d7 (diff) | |
| parent | d67a7e6cfc86352ffdd1098d66831675736677dc (diff) | |
| download | rust-59707c57488eac0766a2e28525a70d6801edf1a7.tar.gz rust-59707c57488eac0766a2e28525a70d6801edf1a7.zip | |
Rollup merge of #77400 - alarsyo:xpy-setup-suggestions, r=jyn514
Fix suggestions for x.py setup #76631 introduced a new `setup` command to x.py By default the command prompts for a profile to use: ``` Welcome to the Rust project! What do you want to do with x.py? a) Contribute to the standard library b) Contribute to the compiler c) Contribute to the compiler, and also modify LLVM or codegen d) Install Rust from source ``` and then displays command suggestions, depending on which profile was chosen. However [the mapping between chosen profile](https://github.com/rust-lang/rust/blob/9cba260df0f1c67ea3690035cd5611a7465a1560/src/bootstrap/setup.rs#L75-L85) and [suggestion](https://github.com/rust-lang/rust/blob/9cba260df0f1c67ea3690035cd5611a7465a1560/src/bootstrap/setup.rs#L42-L47) isn't exact, leading to suggestions not being shown if the user presses `c` or `d`. (because "c" is translated to "llvm" and "d" to "maintainer", but suggestions trigger for "codegen" and "user" respectively) A more thorough refactor would stop using "strings-as-type" to make sure this kind of error doesn't happen, but it may be overkill for that kind of "script" program? Tagging the setup command author: @jyn514
Diffstat (limited to 'src/test/codegen/src-hash-algorithm/src-hash-algorithm-sha256.rs')
0 files changed, 0 insertions, 0 deletions