about summary refs log tree commit diff
path: root/src/test/codegen/src-hash-algorithm
diff options
context:
space:
mode:
authorest31 <MTest31@outlook.com>2020-10-20 18:38:54 +0200
committerest31 <MTest31@outlook.com>2020-10-20 20:21:17 +0200
commit5948e62f3443df626cc803fd3a08bc24e42209e8 (patch)
treec53cd1af2be92f0ef3feb278cb7ab2df8b2e544e /src/test/codegen/src-hash-algorithm
parent4d247ad7d3d2a9f72cd60e281f39b5d85bd6a463 (diff)
downloadrust-5948e62f3443df626cc803fd3a08bc24e42209e8.tar.gz
rust-5948e62f3443df626cc803fd3a08bc24e42209e8.zip
Sync LLVM submodule if it has been initialized
Since having enabled the download-ci-llvm option,
and having rebased on top of f05b47ccdfa63f8b4b9fb47a9aa92381801d3ff1,
I've noticed that I had to update the llvm-project
submodule manually if it was checked out.
Orignally, the submodule update logic was
introduced to reduce the friction for contributors
to manage the submodules, or in other words, to prevent
getting PRs that have unwanted submodule rollbacks
because the contributors didn't run git submodule update.

This commit adds logic to ensure there is no inadvertent
LLVM submodule rollback in a PR if download-ci-llvm
(or llvm-config) is enabled. It will detect whether the
llvm-project submodule is initialized, and if so, update
it in any case. If it is not initialized, behaviour is
kept to not do any update/initialization.

An alternative to the chosen implementation would
be to not pass the --init command line arg to
`git submodule update` for the src/llvm-project
submodule. This would show a confusing error message
however on all builds with an uninitialized repo.
We could pass the --silent param, but we still want
it to print something if it is initialized and has
to update something.
So we just do a manual check for whether the
submodule is initialized.
Diffstat (limited to 'src/test/codegen/src-hash-algorithm')
0 files changed, 0 insertions, 0 deletions