about summary refs log tree commit diff
path: root/src/test/codegen/src-hash-algorithm
diff options
context:
space:
mode:
authorDylan DPC <dylan.dpc@gmail.com>2020-04-11 17:52:10 +0200
committerGitHub <noreply@github.com>2020-04-11 17:52:10 +0200
commit5ecc18f3ece1124a56ff76a74c3eb4153be5b3b8 (patch)
tree81b2b4627905a1c327f1014489ad4367f35dbf26 /src/test/codegen/src-hash-algorithm
parentf9c0ea2862280102bf33e9df81f33b1b7b464e19 (diff)
parentb9d9689e78160c5d09ea627bb1a93468e4872ead (diff)
downloadrust-5ecc18f3ece1124a56ff76a74c3eb4153be5b3b8.tar.gz
rust-5ecc18f3ece1124a56ff76a74c3eb4153be5b3b8.zip
Rollup merge of #70937 - mati865:mingw-staticlib-suffix, r=petrochenkov
Fix staticlib name for *-pc-windows-gnu targets

Fix https://github.com/rust-lang/rust/issues/69904

Guess this will need FCP but opened PR anyway to bring the attention.

In short Rust has been using wrong `foo.lib` format for static libraries when building for `*-pc-windows-gnu` since version [1.8.0](https://github.com/rust-lang/rust/commit/34b4e66736a0fb65235feadbb5178d42bd09ed67).
[LD](https://github.com/bminor/binutils-gdb/blob/f4a220077b03af3a1f905b7dc6dc84c0a06d582f/ld/emultempl/pe.em#L2224-L2227) and [LLD](https://github.com/llvm/llvm-project/blob/0605f5fbe755326e3dbc8daa4fc34453b8c5ac0e/lld/MinGW/Driver.cpp#L140-L141) agree in that regard and only accept static libraries with `libfoo.a` format. So the only thing to break here is when somebody added a hack to rename created library to proper format (like [here](https://gitlab.gnome.org/GNOME/librsvg/-/commit/ad86ab8580c8779fc3eb2bee2422bb116919844e#d5b4de16d947214ec306bd57bed1bd23a939b5f9_197_194)).
Diffstat (limited to 'src/test/codegen/src-hash-algorithm')
0 files changed, 0 insertions, 0 deletions