diff options
| author | Dylan DPC <99973273+Dylan-DPC@users.noreply.github.com> | 2022-07-19 11:38:53 +0530 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-07-19 11:38:53 +0530 |
| commit | 9f6a2fde347430323898baa5d36ac9a028ed37a2 (patch) | |
| tree | 25af3d1765a833105a8a6032ef8a976eb293f886 /src/test/codegen/src-hash-algorithm | |
| parent | af13e55bc3d0133157331137e5c58febe67527ac (diff) | |
| parent | c1c1abc08ab5ae90da2e51ad02246631207113e1 (diff) | |
| download | rust-9f6a2fde347430323898baa5d36ac9a028ed37a2.tar.gz rust-9f6a2fde347430323898baa5d36ac9a028ed37a2.zip | |
Rollup merge of #99335 - Dav1dde:fromstr-docs, r=JohnTitor
Use split_once in FromStr docs
Current implementation:
```rust
fn from_str(s: &str) -> Result<Self, Self::Err> {
let coords: Vec<&str> = s.trim_matches(|p| p == '(' || p == ')' )
.split(',')
.collect();
let x_fromstr = coords[0].parse::<i32>()?;
let y_fromstr = coords[1].parse::<i32>()?;
Ok(Point { x: x_fromstr, y: y_fromstr })
}
```
Creating the vector is not necessary, `split_once` does the job better.
Alternatively we could also remove `trim_matches` with `strip_prefix` and `strip_suffix`:
```rust
let (x, y) = s
.strip_prefix('(')
.and_then(|s| s.strip_suffix(')'))
.and_then(|s| s.split_once(','))
.unwrap();
```
The question is how much 'correctness' is too much and distracts from the example. In a real implementation you would also not unwrap (or originally access the vector without bounds checks), but implementing a custom Error and adding a `From<ParseIntError>` and implementing the `Error` trait adds a lot of code to the example which is not relevant to the `FromStr` trait.
Diffstat (limited to 'src/test/codegen/src-hash-algorithm')
0 files changed, 0 insertions, 0 deletions
