diff options
| author | bors <bors@rust-lang.org> | 2022-05-30 11:22:10 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2022-05-30 11:22:10 +0000 |
| commit | e4ead8a7c6b45440b035e18947d8a98946a917c2 (patch) | |
| tree | 34fa3717474b70e034d95e30081e3be11cb0e256 /src/test/codegen/src-hash-algorithm | |
| parent | f94fa62d69faf5bd63b3772d3ec4f0c76cf2db57 (diff) | |
| parent | 1b5f0462edf813ece280307e8d17d5f93402a739 (diff) | |
| download | rust-e4ead8a7c6b45440b035e18947d8a98946a917c2.tar.gz rust-e4ead8a7c6b45440b035e18947d8a98946a917c2.zip | |
Auto merge of #12412 - yue4u:fix/visibility-completion, r=Veykril
fix: Retrigger visibility completion after parentheses
close #12390
This PR add `(` to trigger_characters as discussed in original issue.
Some questions:
1. Is lsp's `ctx.trigger_character` from `params.context` is the same as `ctx.original_token` inside actually completions?
1. If not what's the difference?
2. if they are the same, it's unnecessary to pass it down from handler at all.
3. if they are the same, maybe we could parse it from fixture directly instead of using the `check_with_trigger_character` I added.
2. Some completion fixtures written as `($0)` ( https://github.com/rust-lang/rust-analyzer/blob/master/crates/ide-completion/src/tests/fn_param.rs#L105 as an example), If I understand correctly they are not invoked outside tests at all?
1. using `ctx.original_token` directly would break these tests as well as parsing trigger_character from fixture for now.
2. I think it make sense to allow `(` triggering these cases?
3. I hope this line up with #12144
Diffstat (limited to 'src/test/codegen/src-hash-algorithm')
0 files changed, 0 insertions, 0 deletions