about summary refs log tree commit diff
path: root/src/test/codegen/stack-alloc-string-slice.rs
diff options
context:
space:
mode:
authorFelix S. Klock II <pnkfelix@pnkfx.org>2015-02-05 16:02:22 +0100
committerFelix S. Klock II <pnkfelix@pnkfx.org>2015-02-05 23:47:17 +0100
commitfa9d2230a65689289f64c897ad30c83251762320 (patch)
tree74fbc5bce88cb1a095021dfd45940b11ee0592ac /src/test/codegen/stack-alloc-string-slice.rs
parent189930fcae287565dcef856ae8d60a83190a4b92 (diff)
downloadrust-fa9d2230a65689289f64c897ad30c83251762320.tar.gz
rust-fa9d2230a65689289f64c897ad30c83251762320.zip
make codemap more robust in face of ill-formed spans.
This can be considered partial work on #8256.

The main observable change: macro expansion sometimes results in spans
where `lo > hi`; so for now, when we have such a span, do not attempt
to return a snippet result.

(Longer term, we might think about whether we could still present a
snippet for the cases where this arises, e.g. perhaps by showing the
whole macro as the snippet, assuming that is the sole cause of such
spans; or by somehow looking up the closest AST node that holds both
`lo` and `hi`, and showing that.)

As a drive-by, revised the API to return a `Result` rather than an
`Option`, with better information-packed error value that should help
us (and maybe also our users) identify the causes of such problems in
the future.  Ideally the call-sites that really want an actual snippet
would be updated to catch the newly added `Err` case and print
something meaningful about it, but that is not part of this PR.
Diffstat (limited to 'src/test/codegen/stack-alloc-string-slice.rs')
0 files changed, 0 insertions, 0 deletions