diff options
| author | bors <bors@rust-lang.org> | 2022-09-14 15:58:21 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2022-09-14 15:58:21 +0000 |
| commit | 2ddbc86bef837b1072159c020c35940ce52ae696 (patch) | |
| tree | 72e4ae3bf5c333d05e259deae907b63f0e5d6436 /src/test/debuginfo/enum-thinlto.rs | |
| parent | 9c9aa928980ca651a75801b90d814a8fb598ed0a (diff) | |
| parent | 6fc6d87fd069470893b6a539a46fa1e2f10ae906 (diff) | |
| download | rust-2ddbc86bef837b1072159c020c35940ce52ae696.tar.gz rust-2ddbc86bef837b1072159c020c35940ce52ae696.zip | |
Auto merge of #8518 - Alexendoo:write-late-pass, r=flip1995
Migrate write.rs to a late pass
changelog: Migrates write.rs from a pre expansion pass to a late pass
changelog: [`positional_named_format_parameters`] is renamed in favour of the rustc lint `named_arguments_used_positionally`
- Macros are now identified by diagnostic items, so will no longer lint user defined macros named, e.g. a custom `print!`
- `print_literal`/`write_literal` no longer lint no longer lint literals that come from macro expansions, e.g. `env!("FOO")`
- `print_with_newline`/`write_with_newline` no longer lint strings with any internal `\r` or `\n`s
~~A false negative, `print_literal`/`write_literal` don't lint format strings that produce `FormatSpec`s, e.g. ones containing pretty print/width/align specifiers~~
Suggestion changes:
- ~~`print_literal`/`write_literal` no longer have suggestions, as the spans for the `{}`s were not easily obtainable~~
- `print_with_newline`/`write_with_newline` has a better suggestion for a sole literal newline, but no longer has suggestions for len > 1 strings that end in a literal newline
- ~~`use_debug` spans are less precise, now point to the whole format string~~
The diff for write.rs is pretty unwieldy, other than for the `declare_clippy_lint!`s I think you'd be better off viewing it as a brand new file rather than looking at the diff, as it's mostly written from scratch
cc #6610, fixes #5721, fixes #7195, fixes #8615
Diffstat (limited to 'src/test/debuginfo/enum-thinlto.rs')
0 files changed, 0 insertions, 0 deletions
