about summary refs log tree commit diff
path: root/src/test/incremental/thinlto
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2018-09-17 18:13:26 +0000
committerbors <bors@rust-lang.org>2018-09-17 18:13:26 +0000
commit354a29a5f1feb55bd799f874786e013beddfd645 (patch)
tree5d8b8dc7b289b1af380df5fdbe86751fe9f42693 /src/test/incremental/thinlto
parent186fe091434b4c20c160b8098a56bb6a841bf6b1 (diff)
parent229df02c0b85c33465d7191a6e085e964e56c1c9 (diff)
downloadrust-354a29a5f1feb55bd799f874786e013beddfd645.tar.gz
rust-354a29a5f1feb55bd799f874786e013beddfd645.zip
Auto merge of #54277 - petrochenkov:afterder, r=alexcrichton
Temporarily prohibit proc macro attributes placed after derives

... and also proc macro attributes used together with `#[test]`/`#[bench]`.

Addresses item 6 from https://github.com/rust-lang/rust/pull/50911#issuecomment-411605393.

The end goal is straightforward predictable left-to-right expansion order for attributes.
Right now derives are expanded last regardless of their relative ordering with macro attributes and right now it's simpler to temporarily prohibit macro attributes placed after derives than changing the expansion order.
I'm not sure whether the new beta is already released or not, but if it's released, then this patch needs to be backported, so the solution needs to be minimal.

How to fix broken code (derives):
- Move macro attributes above derives. This won't change expansion order, they are expanded before derives anyway.

Using attribute macros on same items with `#[test]` and `#[bench]` is prohibited for similar expansion order reasons, but this one is going to be reverted much sooner than restrictions on derives.

How to fix broken code (test/bench):
- Enable `#![feature(plugin)]` (don't ask why).

r? @ghost
Diffstat (limited to 'src/test/incremental/thinlto')
0 files changed, 0 insertions, 0 deletions