about summary refs log tree commit diff
path: root/src/test/incremental/thinlto
diff options
context:
space:
mode:
authorZack M. Davis <code@zackmdavis.net>2018-01-04 23:09:02 -0800
committerZack M. Davis <code@zackmdavis.net>2018-01-06 11:17:29 -0800
commit3cfea33432f223b934bddc207224d90e6a39c280 (patch)
treeb8ba603356f0d233603c5a7bcfa26031488e75c1 /src/test/incremental/thinlto
parent72176cf96cb79a0ebf62972b76dbe68c933bef4d (diff)
downloadrust-3cfea33432f223b934bddc207224d90e6a39c280.tar.gz
rust-3cfea33432f223b934bddc207224d90e6a39c280.zip
wherein careful doc-decoration arithmetic proves quite the ICE-breaker
This `horizontal_trim` function strips the leading whitespace from
doc-comments that have a left-asterisk-margin:

  /**
   * You know what I mean—
   *
   * comments like this!
   */

The index of the column of asterisks is `i`, and if trimming is deemed
possible, we slice each line from `i+1` to the end of the line. But if, in
particular, `i` was 0 _and_ there was an empty line (as in the example
given in the reporting issue), we ended up panicking trying to slice an
empty string from 0+1 (== 1).

Let's tighten our check to say that we can't trim when `i` is even the same
as the length of the line, not just when it's greater. (Any such cases
would panic trying to slice `line` from `line.len()+1`.)

Resolves #47197.
Diffstat (limited to 'src/test/incremental/thinlto')
0 files changed, 0 insertions, 0 deletions