diff options
| author | bors <bors@rust-lang.org> | 2018-02-14 16:05:19 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2018-02-14 16:05:19 +0000 |
| commit | 3ec5a99aaa0084d97a9e845b34fdf03d1462c475 (patch) | |
| tree | 8c5e904998498ba5c058f1676ce1194d6dde0d6f /src/test/incremental/thinlto | |
| parent | 4d2d3fc5dadf894a8ad709a5860a549f2c0b1032 (diff) | |
| parent | e0da9902a1ab8e620be45470130cd72e31d54fc2 (diff) | |
| download | rust-3ec5a99aaa0084d97a9e845b34fdf03d1462c475.tar.gz rust-3ec5a99aaa0084d97a9e845b34fdf03d1462c475.zip | |
Auto merge of #48209 - kennytm:try-fix-48116, r=alexcrichton
Try to fix 48116 and 48192 The bug #48116 happens because of a misoptimization of the `import_path_to_string` function, where a `names` slice is empty but the `!names.is_empty()` branch is executed. https://github.com/rust-lang/rust/blob/4d2d3fc5dadf894a8ad709a5860a549f2c0b1032/src/librustc_resolve/resolve_imports.rs#L1015-L1042 Yesterday, @eddyb had locally reproduced the bug, and [came across the `position` function](https://mozilla.logbot.info/rust-infra/20180214#c14296834) where the `assume()` call is found to be suspicious. We have *not* concluded that this `assume()` causes #48116, but given [the reputation of `assume()`](https://github.com/rust-lang/rust/pull/45501#issuecomment-340159627), this seems higher relevant. Here we try to see if commenting it out can fix the errors. Later @alexcrichton has bisected and found a potential bug [in the LLVM side](https://github.com/rust-lang/rust/issues/48116#issuecomment-365624777). We are currently testing if reverting that LLVM commit is enough to stop the bug. If true, this PR can be reverted (keep the `assume()`) and we could backport the LLVM patch instead. (This PR also includes an earlier commit from #48127 for help debugging ICE happening in compile-fail/parse-fail tests.) The PR also reverts #48059, which seems to cause #48192. r? @alexcrichton cc @eddyb, @arthurprs (#47333)
Diffstat (limited to 'src/test/incremental/thinlto')
0 files changed, 0 insertions, 0 deletions
