diff options
| author | Rich Kadel <richkadel@google.com> | 2021-04-01 12:25:45 -0700 |
|---|---|---|
| committer | Rich Kadel <richkadel@google.com> | 2021-04-02 00:20:10 -0700 |
| commit | fad53880394f0cb4a8e2367fcc218c1fa55539d6 (patch) | |
| tree | e85d3e03e866700be124d83a4d00272b3f2a6975 /src/test/run-make-fulldeps/coverage-spanview/expected_mir_dump.inline/inline.permutate.-------.InstrumentCoverage.0.html | |
| parent | 4fa76a4a7742bb9c1febe33019f5a9e7e4839a65 (diff) | |
| download | rust-fad53880394f0cb4a8e2367fcc218c1fa55539d6.tar.gz rust-fad53880394f0cb4a8e2367fcc218c1fa55539d6.zip | |
Simplify coverage tests
This change reduces the risk of impacting coverage tests on unrelated changes (such as MIR and Span changes), and reduces the burden when blessing coverage changes in case it is necessary. * Remove all spanview tests. The spanview tests were useful during development, but they can be generated as needed, via compiler command line flags. They aren't critical to confirming coverage results. (The coverage report tests are sufficient.) When spanview regeneration was necessary, the diffs were way too hard to read to be useful anyway. So I'm removing them to reduce friction from a feature that is no longer useful. * Remove the requirement for `llvm-cov show --debug` when blessing tests. The `--debug` flag is, unfortunately, only available if LLVM is built with `optimize = false` (in Rust's config.toml). This adds significant time and resource burdens to the contributor's build. As it turns out, for other reasons in the past, I wasn't actually using the debug output (counter info) to validate coverage anymore either, so it was required for no reason, I now realize.
Diffstat (limited to 'src/test/run-make-fulldeps/coverage-spanview/expected_mir_dump.inline/inline.permutate.-------.InstrumentCoverage.0.html')
| -rw-r--r-- | src/test/run-make-fulldeps/coverage-spanview/expected_mir_dump.inline/inline.permutate.-------.InstrumentCoverage.0.html | 183 |
1 files changed, 0 insertions, 183 deletions
diff --git a/src/test/run-make-fulldeps/coverage-spanview/expected_mir_dump.inline/inline.permutate.-------.InstrumentCoverage.0.html b/src/test/run-make-fulldeps/coverage-spanview/expected_mir_dump.inline/inline.permutate.-------.InstrumentCoverage.0.html deleted file mode 100644 index fd72973ccd0..00000000000 --- a/src/test/run-make-fulldeps/coverage-spanview/expected_mir_dump.inline/inline.permutate.-------.InstrumentCoverage.0.html +++ /dev/null @@ -1,183 +0,0 @@ -<!DOCTYPE html> -<!-- - -Preview this file as rendered HTML from the github source at: -https://htmlpreview.github.io/?https://github.com/rust-lang/rust/blob/master/src/test/run-make-fulldeps/coverage-spanview/expected_mir_dump.inline/inline.permutate.-------.InstrumentCoverage.0.html - -For revisions in Pull Requests (PR): - * Replace "rust-lang" with the github PR author - * Replace "master" with the PR branch name - ---> -<html> -<head> -<title>inline.permutate - Coverage Spans</title> -<style> - .line { - counter-increment: line; - } - .line:before { - content: counter(line) ": "; - font-family: Menlo, Monaco, monospace; - font-style: italic; - width: 3.8em; - display: inline-block; - text-align: right; - filter: opacity(50%); - -webkit-user-select: none; - } - .code { - color: #dddddd; - background-color: #222222; - font-family: Menlo, Monaco, monospace; - line-height: 1.4em; - border-bottom: 2px solid #222222; - white-space: pre; - display: inline-block; - } - .odd { - background-color: #55bbff; - color: #223311; - } - .even { - background-color: #ee7756; - color: #551133; - } - .code { - --index: calc(var(--layer) - 1); - padding-top: calc(var(--index) * 0.15em); - filter: - hue-rotate(calc(var(--index) * 25deg)) - saturate(calc(100% - (var(--index) * 2%))) - brightness(calc(100% - (var(--index) * 1.5%))); - } - .annotation { - color: #4444ff; - font-family: monospace; - font-style: italic; - display: none; - -webkit-user-select: none; - } - body:active .annotation { - /* requires holding mouse down anywhere on the page */ - display: inline-block; - } - span:hover .annotation { - /* requires hover over a span ONLY on its first line */ - display: inline-block; - } -</style> -</head> -<body> -<div class="code" style="counter-reset: line 14"><span class="line"><span><span class="code even" style="--layer: 1" title="16:20-16:22: @0[2]: _4 = &(*_1) -16:13-16:23: @0.Call: _3 = length::<T>(move _4) -> [return: bb1, unwind: bb22] -16:9-16:10: @1[1]: FakeRead(ForLet, _3) -17:8-17:9: @1[4]: _6 = _2 -17:13-17:14: @1[6]: _7 = _3 -17:8-17:14: @1[7]: _5 = Eq(move _6, move _7)"><span class="annotation">@0,1⦊</span>fn permutate<T: Copy + Display>(xs: &mut [T], k: usize) {</span></span> -<span class="line"><span class="code even" style="--layer: 1" title="16:20-16:22: @0[2]: _4 = &(*_1) -16:13-16:23: @0.Call: _3 = length::<T>(move _4) -> [return: bb1, unwind: bb22] -16:9-16:10: @1[1]: FakeRead(ForLet, _3) -17:8-17:9: @1[4]: _6 = _2 -17:13-17:14: @1[6]: _7 = _3 -17:8-17:14: @1[7]: _5 = Eq(move _6, move _7)"> let n = length(xs);</span></span> -<span class="line"><span class="code even" style="--layer: 1" title="16:20-16:22: @0[2]: _4 = &(*_1) -16:13-16:23: @0.Call: _3 = length::<T>(move _4) -> [return: bb1, unwind: bb22] -16:9-16:10: @1[1]: FakeRead(ForLet, _3) -17:8-17:9: @1[4]: _6 = _2 -17:13-17:14: @1[6]: _7 = _3 -17:8-17:14: @1[7]: _5 = Eq(move _6, move _7)"> if k == n<span class="annotation">⦉@0,1</span></span></span><span class="code" style="--layer: 0"> </span><span><span class="code odd" style="--layer: 1" title="18:17-18:19: @2[2]: _9 = &(*_1) -18:9-18:20: @2.Call: _8 = display::<T>(move _9) -> [return: bb4, unwind: bb22] -17:15-19:6: @4[2]: _0 = const ()"><span class="annotation">@2,4⦊</span>{</span></span> -<span class="line"><span class="code odd" style="--layer: 1" title="18:17-18:19: @2[2]: _9 = &(*_1) -18:9-18:20: @2.Call: _8 = display::<T>(move _9) -> [return: bb4, unwind: bb22] -17:15-19:6: @4[2]: _0 = const ()"> display(xs);</span></span> -<span class="line"><span class="code odd" style="--layer: 1" title="18:17-18:19: @2[2]: _9 = &(*_1) -18:9-18:20: @2.Call: _8 = display::<T>(move _9) -> [return: bb4, unwind: bb22] -17:15-19:6: @4[2]: _0 = const ()"> }<span class="annotation">⦉@2,4</span></span></span><span class="code" style="--layer: 0"> else if </span><span><span class="code even" style="--layer: 1" title="19:15-19:16: @3[2]: _11 = _2 -19:19-19:20: @3[4]: _12 = _3 -19:15-19:20: @3[5]: _10 = Lt(move _11, move _12)"><span class="annotation">@3⦊</span>k < n<span class="annotation">⦉@3</span></span></span><span class="code" style="--layer: 0"> {</span></span> -<span class="line"><span class="code" style="--layer: 0"> for </span><span><span class="code odd" style="--layer: 1" title="20:13-20:14: @14[1]: _25 = ((_21 as Some).0: usize) -20:13-20:14: @14[3]: _26 = _25 -20:13-20:14: @14[4]: _19 = move _26 -20:13-20:14: @14[5]: _20 = const () -20:13-20:14: @14[13]: FakeRead(ForLet, _28)"><span class="annotation">@12,14,15,16,17,18⦊</span>i<span class="annotation">⦉@12,14,15,16,17,18</span></span></span><span class="code" style="--layer: 0"> in </span><span><span class="code even" style="--layer: 1" title="20:18-20:19: @5[3]: _15 = _2 -20:21-20:22: @5[5]: _16 = _3"><span class="annotation">@5,7⦊</span>k..n<span class="annotation">⦉@5,7</span></span></span><span class="code" style="--layer: 0"> </span><span><span class="code odd" style="--layer: 1" title="21:18-21:20: @14[17]: _31 = &mut (*_1) -21:22-21:23: @14[19]: _32 = _28 -21:25-21:26: @14[21]: _33 = _2 -21:13-21:27: @14.Call: _30 = swap::<T>(move _31, move _32, move _33) -> [return: bb15, unwind: bb22] -22:23-22:25: @15[6]: _35 = &mut (*_1) -22:27-22:28: @15[9]: _37 = _2 -22:27-22:32: @15[10]: _38 = CheckedAdd(_37, const 1_usize) -22:27-22:32: @16[0]: _36 = move (_38.0: usize) -22:13-22:33: @16.Call: _34 = permutate::<T>(move _35, move _36) -> [return: bb17, unwind: bb22] -23:18-23:20: @17[5]: _40 = &mut (*_1) -23:22-23:23: @17[7]: _41 = _28 -23:25-23:26: @17[9]: _42 = _2 -23:13-23:27: @17.Call: _39 = swap::<T>(move _40, move _41, move _42) -> [return: bb18, unwind: bb22] -20:23-24:10: @18[4]: _29 = const ()"><span class="annotation">@12,14,15,16,17,18⦊</span>{</span></span> -<span class="line"><span class="code odd" style="--layer: 1" title="21:18-21:20: @14[17]: _31 = &mut (*_1) -21:22-21:23: @14[19]: _32 = _28 -21:25-21:26: @14[21]: _33 = _2 -21:13-21:27: @14.Call: _30 = swap::<T>(move _31, move _32, move _33) -> [return: bb15, unwind: bb22] -22:23-22:25: @15[6]: _35 = &mut (*_1) -22:27-22:28: @15[9]: _37 = _2 -22:27-22:32: @15[10]: _38 = CheckedAdd(_37, const 1_usize) -22:27-22:32: @16[0]: _36 = move (_38.0: usize) -22:13-22:33: @16.Call: _34 = permutate::<T>(move _35, move _36) -> [return: bb17, unwind: bb22] -23:18-23:20: @17[5]: _40 = &mut (*_1) -23:22-23:23: @17[7]: _41 = _28 -23:25-23:26: @17[9]: _42 = _2 -23:13-23:27: @17.Call: _39 = swap::<T>(move _40, move _41, move _42) -> [return: bb18, unwind: bb22] -20:23-24:10: @18[4]: _29 = const ()"> swap(xs, i, k);</span></span> -<span class="line"><span class="code odd" style="--layer: 1" title="21:18-21:20: @14[17]: _31 = &mut (*_1) -21:22-21:23: @14[19]: _32 = _28 -21:25-21:26: @14[21]: _33 = _2 -21:13-21:27: @14.Call: _30 = swap::<T>(move _31, move _32, move _33) -> [return: bb15, unwind: bb22] -22:23-22:25: @15[6]: _35 = &mut (*_1) -22:27-22:28: @15[9]: _37 = _2 -22:27-22:32: @15[10]: _38 = CheckedAdd(_37, const 1_usize) -22:27-22:32: @16[0]: _36 = move (_38.0: usize) -22:13-22:33: @16.Call: _34 = permutate::<T>(move _35, move _36) -> [return: bb17, unwind: bb22] -23:18-23:20: @17[5]: _40 = &mut (*_1) -23:22-23:23: @17[7]: _41 = _28 -23:25-23:26: @17[9]: _42 = _2 -23:13-23:27: @17.Call: _39 = swap::<T>(move _40, move _41, move _42) -> [return: bb18, unwind: bb22] -20:23-24:10: @18[4]: _29 = const ()"> permutate(xs, k + 1);</span></span> -<span class="line"><span class="code odd" style="--layer: 1" title="21:18-21:20: @14[17]: _31 = &mut (*_1) -21:22-21:23: @14[19]: _32 = _28 -21:25-21:26: @14[21]: _33 = _2 -21:13-21:27: @14.Call: _30 = swap::<T>(move _31, move _32, move _33) -> [return: bb15, unwind: bb22] -22:23-22:25: @15[6]: _35 = &mut (*_1) -22:27-22:28: @15[9]: _37 = _2 -22:27-22:32: @15[10]: _38 = CheckedAdd(_37, const 1_usize) -22:27-22:32: @16[0]: _36 = move (_38.0: usize) -22:13-22:33: @16.Call: _34 = permutate::<T>(move _35, move _36) -> [return: bb17, unwind: bb22] -23:18-23:20: @17[5]: _40 = &mut (*_1) -23:22-23:23: @17[7]: _41 = _28 -23:25-23:26: @17[9]: _42 = _2 -23:13-23:27: @17.Call: _39 = swap::<T>(move _40, move _41, move _42) -> [return: bb18, unwind: bb22] -20:23-24:10: @18[4]: _29 = const ()"> swap(xs, i, k);</span></span> -<span class="line"><span class="code odd" style="--layer: 1" title="21:18-21:20: @14[17]: _31 = &mut (*_1) -21:22-21:23: @14[19]: _32 = _28 -21:25-21:26: @14[21]: _33 = _2 -21:13-21:27: @14.Call: _30 = swap::<T>(move _31, move _32, move _33) -> [return: bb15, unwind: bb22] -22:23-22:25: @15[6]: _35 = &mut (*_1) -22:27-22:28: @15[9]: _37 = _2 -22:27-22:32: @15[10]: _38 = CheckedAdd(_37, const 1_usize) -22:27-22:32: @16[0]: _36 = move (_38.0: usize) -22:13-22:33: @16.Call: _34 = permutate::<T>(move _35, move _36) -> [return: bb17, unwind: bb22] -23:18-23:20: @17[5]: _40 = &mut (*_1) -23:22-23:23: @17[7]: _41 = _28 -23:25-23:26: @17[9]: _42 = _2 -23:13-23:27: @17.Call: _39 = swap::<T>(move _40, move _41, move _42) -> [return: bb18, unwind: bb22] -20:23-24:10: @18[4]: _29 = const ()"> }<span class="annotation">⦉@12,14,15,16,17,18</span></span></span><span class="code" style="--layer: 0"></span></span> -<span class="line"><span class="code" style="--layer: 0"> } else </span><span><span class="code even" style="--layer: 1" title="26:9-26:16: @6.Call: _43 = error() -> [return: bb19, unwind: bb22] -25:12-27:6: @19[1]: _0 = const ()"><span class="annotation">@6,19⦊</span>{</span></span> -<span class="line"><span class="code even" style="--layer: 1" title="26:9-26:16: @6.Call: _43 = error() -> [return: bb19, unwind: bb22] -25:12-27:6: @19[1]: _0 = const ()"> error();</span></span> -<span class="line"><span class="code even" style="--layer: 1" title="26:9-26:16: @6.Call: _43 = error() -> [return: bb19, unwind: bb22] -25:12-27:6: @19[1]: _0 = const ()"> }<span class="annotation">⦉@6,19</span></span></span><span class="code" style="--layer: 0"></span></span> -<span class="line"><span class="code" style="--layer: 0">}</span><span><span class="code odd" style="--layer: 1" title="28:2-28:2: @21.Return: return"><span class="annotation">@21⦊</span>‸<span class="annotation">⦉@21</span></span></span></span></div> -</body> -</html> |