diff options
| author | Corey Farwell <coreyf@rwell.org> | 2017-02-09 12:14:23 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-02-09 12:14:23 -0500 |
| commit | 7e2b2f30cd55cf2c506852a14ad01c4214406f52 (patch) | |
| tree | 78bfc4f4adc6f417fd17156809faeddb49a00741 /src/test/run-pass/thinlto | |
| parent | 7bd0da7e89faea251e77215ec70f7a5b2c26a3f8 (diff) | |
| parent | 2589f4a7511ab04a3325b0372cd2ae174940c6c8 (diff) | |
| download | rust-7e2b2f30cd55cf2c506852a14ad01c4214406f52.tar.gz rust-7e2b2f30cd55cf2c506852a14ad01c4214406f52.zip | |
Rollup merge of #39682 - solson:fix-unaligned-read, r=eddyb
Fix unsafe unaligned loads in test.
r? @eddyb
cc @Aatch @nikomatsakis
The `#[derive(PartialEq, Debug)]` impls on a packed struct contain undefined behaviour. Both generated impls take references to unaligned fields, which will fail to compile once we correctly treat that as unsafe (see https://github.com/rust-lang/rust/issues/27060).
This UB was found by running the test under [Miri](https://github.com/solson/miri/) which rejects these unsafe unaligned loads. 😄
Here's a simpler example:
```rust
struct Packed {
a: u8,
b: u64,
}
```
It expands to:
```rust
fn fmt(&self, __arg_0: &mut ::std::fmt::Formatter) -> ::std::fmt::Result {
match *self {
Packed { a: ref __self_0_0, b: ref __self_0_1 } => { // BAD: these patterns are unsafe
let mut builder = __arg_0.debug_struct("Packed");
let _ = builder.field("a", &&(*__self_0_0));
let _ = builder.field("b", &&(*__self_0_1));
builder.finish()
}
}
}
```
and
```rust
fn eq(&self, __arg_0: &Packed) -> bool {
match *__arg_0 {
Packed { a: ref __self_1_0, b: ref __self_1_1 } => // BAD: these patterns are unsafe
match *self {
Packed { a: ref __self_0_0, b: ref __self_0_1 } => // BAD: these patterns are unsafe
true && (*__self_0_0) == (*__self_1_0) &&
(*__self_0_1) == (*__self_1_1),
},
}
}
```
Diffstat (limited to 'src/test/run-pass/thinlto')
0 files changed, 0 insertions, 0 deletions
