diff options
| author | Michael Howell <michael@notriddle.com> | 2022-06-28 14:56:24 -0700 |
|---|---|---|
| committer | Michael Howell <michael@notriddle.com> | 2022-06-28 17:29:37 -0700 |
| commit | cb8a7388fa0106793c3ea709528fa1408c7cf87b (patch) | |
| tree | 6b23aef2bf2cce6b6b243a24fd4ba06a2ac2a7b2 /src/test/rustdoc-gui | |
| parent | cec6988a07d30843f4b1c038fb6ff62f15d1a5e1 (diff) | |
| download | rust-cb8a7388fa0106793c3ea709528fa1408c7cf87b.tar.gz rust-cb8a7388fa0106793c3ea709528fa1408c7cf87b.zip | |
rustdoc: fix keyboard shortcuts bug in settings menu
This commit fixes the keyboard shorts code to call localStorage every time a key is pressed. This matters because you're supposed to be able to change a setting and have it immediately take effect.
Diffstat (limited to 'src/test/rustdoc-gui')
| -rw-r--r-- | src/test/rustdoc-gui/settings.goml | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/src/test/rustdoc-gui/settings.goml b/src/test/rustdoc-gui/settings.goml index 237a4751a8d..a43c712ef9a 100644 --- a/src/test/rustdoc-gui/settings.goml +++ b/src/test/rustdoc-gui/settings.goml @@ -121,6 +121,17 @@ local-storage: {"rustdoc-disable-shortcuts": "false"} click: ".setting-line:last-child .toggle .label" assert-local-storage: {"rustdoc-disable-shortcuts": "true"} +// Make sure that "Disable keyboard shortcuts" actually took effect. +press-key: "?" +wait-for-css: ("#settings-menu .popover", {"display": "block"}) + +// Now turn keyboard shortcuts back on, and see if they work. +click: ".setting-line:last-child .toggle .label" +assert-local-storage: {"rustdoc-disable-shortcuts": "false"} +press-key: "?" +wait-for-css: ("#help-button .popover", {"display": "block"}) +assert-css: ("#settings-menu .popover", {"display": "none"}) + // Now we go to the settings page to check that the CSS is loaded as expected. goto: file://|DOC_PATH|/settings.html wait-for: "#settings" |