about summary refs log tree commit diff
path: root/src/test/rustdoc-ui/coverage/private.rs
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2020-04-13 16:28:57 +0000
committerbors <bors@rust-lang.org>2020-04-13 16:28:57 +0000
commitc58c53274401acdc739f177aa3e408241e2e52d8 (patch)
treef923c7b9b7852ed83e294cdb9932d0440cc8137f /src/test/rustdoc-ui/coverage/private.rs
parent5179ebe2064e15196c5be1f8df950736140b8fdd (diff)
parentcb6a5609b365779e62b404cbb730fa9e2a8e88b9 (diff)
downloadrust-c58c53274401acdc739f177aa3e408241e2e52d8.tar.gz
rust-c58c53274401acdc739f177aa3e408241e2e52d8.zip
Auto merge of #70989 - eddyb:mir-opt-32-pr-ci, r=Mark-Simulacrum
 ci: run mir-opt tests on PR CI also as 32-bit (for `EMIT_MIR_FOR_EACH_BIT_WIDTH`).

Background: #69916 and [`src/test/mir-opt/README.md`](https://github.com/rust-lang/rust/blob/master/src/test/mir-opt/README.md):
> By default 32 bit and 64 bit targets use the same dump files, which can be problematic in the
presence of pointers in constants or other bit width dependent things. In that case you can add
>
> ```
> // EMIT_MIR_FOR_EACH_BIT_WIDTH
> ```
>
> to your test, causing separate files to be generated for 32bit and 64bit systems.

However, if you change the output of such a test (intentionally or not), or if you add a test and it varies between 32-bit and 64-bit platforms, you have to run this command (for a x64 linux host):
`./x.py test --stage 1 --target x86_64-unknown-linux-gnu --target i686-unknown-linux-gnu --bless  src/test/mir-opt`

Otherwise, bors trying to merge the PR will fail, since we test 32-bit targets there.
But we don't on PR CI, which means there's no way the PR author would know (unless they were burnt by this already and know what to look for).

This PR resolves that by running `mir-opt` tests for ~~`i686-unknown-linux-gnu`~~, on PR CI.
**EDIT**: switched to `armv5te-unknown-linux-gnueabi` to work around LLVM 7 crashes (see https://github.com/rust-lang/compiler-builtins/pull/311#issuecomment-612270089), found during testing.

cc @rust-lang/wg-mir-opt @rust-lang/infra
Diffstat (limited to 'src/test/rustdoc-ui/coverage/private.rs')
0 files changed, 0 insertions, 0 deletions