about summary refs log tree commit diff
path: root/src/test/ui/command/command-pre-exec.rs
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2021-08-01 16:45:47 +0000
committerbors <bors@rust-lang.org>2021-08-01 16:45:47 +0000
commit4e21ef2a4eca12180e24a345d66066fc1e4e36da (patch)
treef4a6738e9cc0b047efed979e2f5a9d70b9b851b2 /src/test/ui/command/command-pre-exec.rs
parent2e9c8705e94826da6aebe46512b4e3bbfc9e008f (diff)
parent4a832d32f232a68acdabfd29e526d2a4b6366a1c (diff)
downloadrust-4e21ef2a4eca12180e24a345d66066fc1e4e36da.tar.gz
rust-4e21ef2a4eca12180e24a345d66066fc1e4e36da.zip
Auto merge of #81825 - voidc:pidfd, r=joshtriplett
Add Linux-specific pidfd process extensions (take 2)

Continuation of #77168.
I addressed the following concerns from the original PR:

- make `CommandExt` and `ChildExt` sealed traits
- wrap file descriptors in `PidFd` struct representing ownership over the fd
- add `take_pidfd` to take the fd out of `Child`
- close fd when dropped

Tracking Issue: #82971
Diffstat (limited to 'src/test/ui/command/command-pre-exec.rs')
-rw-r--r--src/test/ui/command/command-pre-exec.rs25
1 files changed, 19 insertions, 6 deletions
diff --git a/src/test/ui/command/command-pre-exec.rs b/src/test/ui/command/command-pre-exec.rs
index 61914e22930..10a8b19159e 100644
--- a/src/test/ui/command/command-pre-exec.rs
+++ b/src/test/ui/command/command-pre-exec.rs
@@ -8,8 +8,6 @@
 // ignore-sgx no processes
 #![feature(process_exec, rustc_private)]
 
-extern crate libc;
-
 use std::env;
 use std::io::Error;
 use std::os::unix::process::CommandExt;
@@ -17,6 +15,23 @@ use std::process::Command;
 use std::sync::atomic::{AtomicUsize, Ordering};
 use std::sync::Arc;
 
+#[cfg(not(target_os = "linux"))]
+fn getpid() -> u32 {
+    use std::process;
+    process::id()
+}
+
+/// We need to directly use the getpid syscall instead of using `process::id()`
+/// because the libc wrapper might return incorrect values after a process was
+/// forked.
+#[cfg(target_os = "linux")]
+fn getpid() -> u32 {
+    extern crate libc;
+    unsafe {
+        libc::syscall(libc::SYS_getpid) as _
+    }
+}
+
 fn main() {
     if let Some(arg) = env::args().nth(1) {
         match &arg[..] {
@@ -68,14 +83,12 @@ fn main() {
     };
     assert_eq!(output.raw_os_error(), Some(102));
 
-    let pid = unsafe { libc::getpid() };
-    assert!(pid >= 0);
+    let pid = getpid();
     let output = unsafe {
         Command::new(&me)
             .arg("empty")
             .pre_exec(move || {
-                let child = libc::getpid();
-                assert!(child >= 0);
+                let child = getpid();
                 assert!(pid != child);
                 Ok(())
             })