about summary refs log tree commit diff
path: root/src/test/ui/pattern
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2022-04-16 06:55:28 +0000
committerbors <bors@rust-lang.org>2022-04-16 06:55:28 +0000
commit07bb916d44a66d2caba427c7ee132bbeb245977b (patch)
tree81950b54d9588bdfb9ecd7d96233b2e4865f66e9 /src/test/ui/pattern
parent080d5452e1bb6e18e12a073d4d0283fd9b6dac0b (diff)
parentb6c87c555f3b664f558d137d5f7696a07488157e (diff)
downloadrust-07bb916d44a66d2caba427c7ee132bbeb245977b.tar.gz
rust-07bb916d44a66d2caba427c7ee132bbeb245977b.zip
Auto merge of #92364 - jackh726:Quantumplation/65853/param-heuristics, r=estebank
Better method call error messages

Rebase/continuation of #71827

~Based on #92360~
~Based on #93118~

There's a decent description in #71827 that I won't copy here (for now at least)

In addition to rebasing, I've tried to restore most of the original suggestions for invalid arguments. Unfortunately, this does make some of the errors a bit verbose. To fix this will require a bit of refactoring to some of the generalized error suggestion functions, and I just don't have the time to go into it right now.

I think this is in a state that the error messages are overall better than before without a reduction in the suggestions given.

~I've tried to split out some of the easier and self-contained changes into separate commits (mostly in #92360, but also one here). There might be more than can be done here, but again just lacking time.~

r? `@estebank` as the original reviewer of #71827
Diffstat (limited to 'src/test/ui/pattern')
-rw-r--r--src/test/ui/pattern/pattern-error-continue.stderr10
1 files changed, 9 insertions, 1 deletions
diff --git a/src/test/ui/pattern/pattern-error-continue.stderr b/src/test/ui/pattern/pattern-error-continue.stderr
index c800afdae2a..4c2eff63ab5 100644
--- a/src/test/ui/pattern/pattern-error-continue.stderr
+++ b/src/test/ui/pattern/pattern-error-continue.stderr
@@ -46,7 +46,15 @@ error[E0308]: mismatched types
   --> $DIR/pattern-error-continue.rs:28:7
    |
 LL |     f(true);
-   |       ^^^^ expected `char`, found `bool`
+   |     - ^^^^ expected `char`, found `bool`
+   |     |
+   |     arguments to this function are incorrect
+   |
+note: function defined here
+  --> $DIR/pattern-error-continue.rs:13:4
+   |
+LL | fn f(_c: char) {}
+   |    ^ --------
 
 error: aborting due to 5 previous errors