about summary refs log tree commit diff
path: root/src/test/ui/thinlto
diff options
context:
space:
mode:
authorMark Rousskov <mark.simulacrum@gmail.com>2019-07-18 11:29:37 -0400
committerGitHub <noreply@github.com>2019-07-18 11:29:37 -0400
commitcc16d0486933e02237190366de2eb43df2215c11 (patch)
treede077522aa3cc69e3618895af80bc587a95b267f /src/test/ui/thinlto
parent7fc80b6bc604d88b7be8da60765341efa69d8648 (diff)
parent3622311d53b6aeb454bfc55cec5e6b06f88597c8 (diff)
downloadrust-cc16d0486933e02237190366de2eb43df2215c11.tar.gz
rust-cc16d0486933e02237190366de2eb43df2215c11.zip
Rollup merge of #62615 - wesleywiser:pgo_error, r=nagisa
 Only error about MSVC + PGO + unwind if we're generating code

In #61853, we changed the error when using PGO & MSVC toolchain & panic=unwind into a warning. However, in the compiler team meeting on 2019-07-11, we found that not everybody was in favor of that change because of the possibility of broken binaries.

This PR reverts that change so this is again an error. However, to work around an [issue the Firefox team is having](https://github.com/rust-lang/rust/issues/61002#issuecomment-500075739), we will only emit the error if we're actually supposed to generate a binary. If the `rustc` is invoked with `--print` arguments (which means that no binary will actually be emitted), then we won't emit the error because there is not a possibility of the issue occurring.

cc @EricRahm @nikomatsakis @pnkfelix @Centril
Diffstat (limited to 'src/test/ui/thinlto')
0 files changed, 0 insertions, 0 deletions