diff options
| author | Alex Crichton <alex@alexcrichton.com> | 2018-07-31 15:45:11 -0700 |
|---|---|---|
| committer | Alex Crichton <alex@alexcrichton.com> | 2018-08-01 07:29:24 -0700 |
| commit | 27b3cb552d8e7b4f5d2faad841df7a79f09fd362 (patch) | |
| tree | 48d0cf779a79e2ed56708d4bd59f60cd9f90221a /src/test | |
| parent | f89817997ac0aa100bf91997194ad85a7e59f743 (diff) | |
rustc: Trim down the `rust_2018_idioms` lint group
These migration lints aren't all up to par in terms of a good migration experience. Some, like `unreachable_pub`, hit bugs like #52665 and unprepared macros to be handled enough of the time. Others like linting against `#[macro_use]` are swimming upstream in an ecosystem that's not quite ready (and slightly buggy pending a few current PRs). The general idea is that we will continue to recommend the `rust_2018_idioms` lint group as part of the transition guide (as an optional step) but we'll be much more selective about which lints make it into this group. Only those with a strong track record of not causing too much churn will make the cut. cc #52679
Diffstat (limited to 'src/test')
| -rw-r--r-- | src/test/ui/rust-2018/macro-use-warned-against.rs | 2 | ||||
| -rw-r--r-- | src/test/ui/rust-2018/macro-use-warned-against.stderr | 11 |
2 files changed, 6 insertions, 7 deletions
diff --git a/src/test/ui/rust-2018/macro-use-warned-against.rs b/src/test/ui/rust-2018/macro-use-warned-against.rs index f7a6b560280..f50419434ae 100644 --- a/src/test/ui/rust-2018/macro-use-warned-against.rs +++ b/src/test/ui/rust-2018/macro-use-warned-against.rs @@ -12,7 +12,7 @@ // aux-build:macro-use-warned-against2.rs // compile-pass -#![warn(rust_2018_idioms, unused)] +#![warn(macro_use_extern_crate, unused)] #![feature(use_extern_macros)] #[macro_use] //~ WARN should be replaced at use sites with a `use` statement diff --git a/src/test/ui/rust-2018/macro-use-warned-against.stderr b/src/test/ui/rust-2018/macro-use-warned-against.stderr index bebad31510f..7af404fab79 100644 --- a/src/test/ui/rust-2018/macro-use-warned-against.stderr +++ b/src/test/ui/rust-2018/macro-use-warned-against.stderr @@ -7,9 +7,8 @@ LL | #[macro_use] //~ WARN should be replaced at use sites with a `use` statemen note: lint level defined here --> $DIR/macro-use-warned-against.rs:15:9 | -LL | #![warn(rust_2018_idioms, unused)] - | ^^^^^^^^^^^^^^^^ - = note: #[warn(macro_use_extern_crate)] implied by #[warn(rust_2018_idioms)] +LL | #![warn(macro_use_extern_crate, unused)] + | ^^^^^^^^^^^^^^^^^^^^^^ warning: unused `#[macro_use]` import --> $DIR/macro-use-warned-against.rs:20:1 @@ -18,9 +17,9 @@ LL | #[macro_use] //~ WARN unused `#[macro_use]` | ^^^^^^^^^^^^ | note: lint level defined here - --> $DIR/macro-use-warned-against.rs:15:27 + --> $DIR/macro-use-warned-against.rs:15:33 | -LL | #![warn(rust_2018_idioms, unused)] - | ^^^^^^ +LL | #![warn(macro_use_extern_crate, unused)] + | ^^^^^^ = note: #[warn(unused_imports)] implied by #[warn(unused)] |