diff options
| author | Tyler Mandry <tmandry@gmail.com> | 2020-08-13 18:00:19 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-08-13 18:00:19 -0700 |
| commit | d000fb1ca837f175dc5722bbbc4fe15416eb5cd9 (patch) | |
| tree | 9c3409e5bfc32afcf146f638c60a4f751576c5cf /src/test | |
| parent | b4966a8936be55bc2d95aa134127daae58cd47bf (diff) | |
| parent | d4593af78fb2929f0c46e5e4fc041092b7195f81 (diff) | |
| download | rust-d000fb1ca837f175dc5722bbbc4fe15416eb5cd9.tar.gz rust-d000fb1ca837f175dc5722bbbc4fe15416eb5cd9.zip | |
Rollup merge of #75471 - richkadel:llvm-program-name, r=wesleywiser
Change registered "program name" for -Cllvm-args usage messages While debugging a codegen issue, I tried adding LLVM options with the rustc -Cllvm-args option, and was confused by the error and usage messaging. The LLVM "program name" argument is set to "rustc", and command line error messages make it look like invalid arguments are "rustc" arguments, not LLVM. I changed this argument so error messages and the "-help" usage feedback is easier to understand and react to. (Clang does something similar.) r? @wesleywiser
Diffstat (limited to 'src/test')
| -rw-r--r-- | src/test/ui/unknown-llvm-arg.rs | 22 | ||||
| -rw-r--r-- | src/test/ui/unknown-llvm-arg.stderr | 1 |
2 files changed, 23 insertions, 0 deletions
diff --git a/src/test/ui/unknown-llvm-arg.rs b/src/test/ui/unknown-llvm-arg.rs new file mode 100644 index 00000000000..289bae24f81 --- /dev/null +++ b/src/test/ui/unknown-llvm-arg.rs @@ -0,0 +1,22 @@ +// compile-flags: -Cllvm-args=-not-a-real-llvm-arg +// normalize-stderr-test "--help" -> "-help" +// normalize-stderr-test "\n(\n|.)*" -> "" + +// I'm seeing "--help" locally, but "-help" in CI, so I'm normalizing it to just "-help". + +// Note that the rustc-supplied "program name", given when invoking LLVM, is used by LLVM to +// generate user-facing error messages and a usage (--help) messages. If the program name is +// `rustc`, the usage message in response to `--llvm-args="--help"` starts with: +// ``` +// USAGE: rustc [options] +// ``` +// followed by the list of options not to `rustc` but to `llvm`. +// +// On the other hand, if the program name is set to `rustc -Cllvm-args="..." with`, the usage +// message is more clear: +// ``` +// USAGE: rustc -Cllvm-args="..." with [options] +// ``` +// This test captures the effect of the current program name setting on LLVM command line +// error messages. +fn main() {} diff --git a/src/test/ui/unknown-llvm-arg.stderr b/src/test/ui/unknown-llvm-arg.stderr new file mode 100644 index 00000000000..e1d3cfea28f --- /dev/null +++ b/src/test/ui/unknown-llvm-arg.stderr @@ -0,0 +1 @@ +rustc -Cllvm-args="..." with: Unknown command line argument '-not-a-real-llvm-arg'. Try: 'rustc -Cllvm-args="..." with -help' \ No newline at end of file |