diff options
| author | Dylan DPC <dylan.dpc@gmail.com> | 2021-01-13 03:20:23 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-01-13 03:20:23 +0100 |
| commit | d64e703e4fb52479d432b81a369e64246ee5c433 (patch) | |
| tree | 13a565b8e5cc9e5877175e4877efc90f90490392 /src/test | |
| parent | 7ce8246a2393af53492d2c415f6f415099ce08d2 (diff) | |
| parent | 82d0c597bf49ebdf44060f059e90315b87f7f026 (diff) | |
Rollup merge of #80922 - spastorino:revert-inline-always-in-debug, r=wesleywiser
Revert "Auto merge of #76896 - spastorino:codegen-inline-fns2 This reverts commit ddf2cc7f8eb34f1a63b491d6a52e3e8208393c09, reversing changes made to 937f629535f38c655267f1ed21ce6830f592f5df. As `@alexcrichton` pointed out in https://github.com/rust-lang/rust/issues/80916 there's a problem with the taken approach.
Diffstat (limited to 'src/test')
| -rw-r--r-- | src/test/incremental/hygiene/load_cached_hygiene.rs | 9 | ||||
| -rw-r--r-- | src/test/incremental/remapped_paths_cc/main.rs | 9 | ||||
| -rw-r--r-- | src/test/run-make-fulldeps/inline-always-many-cgu/Makefile | 7 |
3 files changed, 4 insertions, 21 deletions
diff --git a/src/test/incremental/hygiene/load_cached_hygiene.rs b/src/test/incremental/hygiene/load_cached_hygiene.rs index d6a5cb993a4..8124141418b 100644 --- a/src/test/incremental/hygiene/load_cached_hygiene.rs +++ b/src/test/incremental/hygiene/load_cached_hygiene.rs @@ -1,5 +1,5 @@ // revisions:rpass1 rpass2 -// compile-flags: -Z query-dep-graph -O +// compile-flags: -Z query-dep-graph // aux-build:cached_hygiene.rs // This tests the folllowing scenario @@ -19,12 +19,7 @@ // the metadata. Specifically, we were not resetting `orig_id` // for an `EpxnData` generate in the current crate, which would cause // us to serialize the `ExpnId` pointing to a garbage location in -// the metadata.o - -// NOTE: We're explicitly passing the `-O` optimization flag because if optimizations are not -// enabled, then rustc will ignore the `#[inline(always)]` attribute which means we do not load -// the optimized mir for the unmodified function to be loaded and so the CGU containing that -// function will be reused. +// the metadata. #![feature(rustc_attrs)] diff --git a/src/test/incremental/remapped_paths_cc/main.rs b/src/test/incremental/remapped_paths_cc/main.rs index 735635029da..b01f02444ea 100644 --- a/src/test/incremental/remapped_paths_cc/main.rs +++ b/src/test/incremental/remapped_paths_cc/main.rs @@ -1,18 +1,11 @@ // revisions:rpass1 rpass2 rpass3 -// compile-flags: -Z query-dep-graph -g -O +// compile-flags: -Z query-dep-graph -g // aux-build:extern_crate.rs // ignore-asmjs wasm2js does not support source maps yet - // This test case makes sure that we detect if paths emitted into debuginfo // are changed, even when the change happens in an external crate. -// NOTE: We're explicitly passing the `-O` optimization flag because if no optimizations are -// requested, rustc will ignore the `#[inline]` attribute. This is a performance optimization for -// non-optimized builds which causes us to generate fewer copies of inlined functions when -// runtime performance doesn't matter. Without this flag, the function will go into a different -// CGU which can be reused by this crate. - #![feature(rustc_attrs)] #![rustc_partition_reused(module="main", cfg="rpass2")] diff --git a/src/test/run-make-fulldeps/inline-always-many-cgu/Makefile b/src/test/run-make-fulldeps/inline-always-many-cgu/Makefile index d12a23fbbf0..0cab955f644 100644 --- a/src/test/run-make-fulldeps/inline-always-many-cgu/Makefile +++ b/src/test/run-make-fulldeps/inline-always-many-cgu/Makefile @@ -1,12 +1,7 @@ -include ../tools.mk all: - $(RUSTC) foo.rs --emit llvm-ir -C codegen-units=2 -C opt-level=0 - if ![cat $(TMPDIR)/*.ll | $(CGREP) -e '\bcall\b']; then \ - echo "not found call instruction when one was expected"; \ - exit 1; \ - fi - $(RUSTC) foo.rs --emit llvm-ir -C codegen-units=2 -C opt-level=1 + $(RUSTC) foo.rs --emit llvm-ir -C codegen-units=2 if cat $(TMPDIR)/*.ll | $(CGREP) -e '\bcall\b'; then \ echo "found call instruction when one wasn't expected"; \ exit 1; \ |
