diff options
| author | bors <bors@rust-lang.org> | 2015-09-27 05:29:39 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2015-09-27 05:29:39 +0000 |
| commit | dde7283b807792dab4b2a10bace9b015a28aea02 (patch) | |
| tree | 9de741bf6919fff0f378c615b35c12e122d80bb9 /src/test | |
| parent | 90c04d0362699637a399a33a321ece7c644e449b (diff) | |
| parent | 91f7c60d2d77423ed8f163beb6f76b92de03a09f (diff) | |
Auto merge of #28651 - dotdash:exhaustive_match, r=eddyb
By putting an "unreachable" instruction into the default arm of a switch
instruction we can let LLVM know that the match is exhaustive, allowing
for better optimizations.
For example, this match:
```rust
pub enum Enum {
One,
Two,
Three,
}
impl Enum {
pub fn get_disc(self) -> u8 {
match self {
Enum::One => 0,
Enum::Two => 1,
Enum::Three => 2,
}
}
}
```
Currently compiles to this on x86_64:
```asm
.cfi_startproc
movzbl %dil, %ecx
cmpl $1, %ecx
setne %al
testb %cl, %cl
je .LBB0_2
incb %al
movb %al, %dil
.LBB0_2:
movb %dil, %al
retq
.Lfunc_end0:
```
But with this change we get:
```asm
.cfi_startproc
movb %dil, %al
retq
.Lfunc_end0:
```
Diffstat (limited to 'src/test')
| -rw-r--r-- | src/test/codegen/match.rs | 30 |
1 files changed, 30 insertions, 0 deletions
diff --git a/src/test/codegen/match.rs b/src/test/codegen/match.rs new file mode 100644 index 00000000000..ac47f6082e3 --- /dev/null +++ b/src/test/codegen/match.rs @@ -0,0 +1,30 @@ +// Copyright 2015 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or +// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license +// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +// compile-flags: -C no-prepopulate-passes + +#![crate_type = "lib"] + +pub enum E { + A, + B, +} + +// CHECK-LABEL: @exhaustive_match +#[no_mangle] +pub fn exhaustive_match(e: E) { +// CHECK: switch{{.*}}, label %[[DEFAULT:[a-zA-Z0-9_]+]] +// CHECK: [[DEFAULT]]: +// CHECK-NEXT: unreachable + match e { + E::A => (), + E::B => (), + } +} |
