about summary refs log tree commit diff
path: root/src/tools/rust-analyzer/crates
diff options
context:
space:
mode:
authorTyler Mandry <tmandry@gmail.com>2024-08-15 15:18:15 -0700
committerTyler Mandry <tmandry@gmail.com>2024-08-15 15:18:15 -0700
commit23c8dcd3cb78cc0adbbce29eefc84195325a2598 (patch)
treeab7928d3ad2dddaa196dd448b910c60452fa3dac /src/tools/rust-analyzer/crates
parenta594a2d46b2794a3812f1dd8c140e9084b666520 (diff)
Allow flycheck process to exit gracefully
Assuming it isn't cancelled. Closes #17902.

The only place CommandHandle::join is used is when the flycheck command
finishes, so this commit changes the behavior of the method itself.
Diffstat (limited to 'src/tools/rust-analyzer/crates')
-rw-r--r--src/tools/rust-analyzer/crates/rust-analyzer/src/command.rs1
1 files changed, 0 insertions, 1 deletions
diff --git a/src/tools/rust-analyzer/crates/rust-analyzer/src/command.rs b/src/tools/rust-analyzer/crates/rust-analyzer/src/command.rs
index f1009eb4660..b19a1b8d167 100644
--- a/src/tools/rust-analyzer/crates/rust-analyzer/src/command.rs
+++ b/src/tools/rust-analyzer/crates/rust-analyzer/src/command.rs
@@ -148,7 +148,6 @@ impl<T: ParseFromLine> CommandHandle<T> {
     }
 
     pub(crate) fn join(mut self) -> io::Result<()> {
-        let _ = self.child.0.kill();
         let exit_status = self.child.0.wait()?;
         let (read_at_least_one_message, error) = self.thread.join()?;
         if read_at_least_one_message || exit_status.success() {