diff options
| author | Kevin Yeh <kevinyeah@utexas.edu> | 2015-11-19 01:53:25 -0600 |
|---|---|---|
| committer | Kevin Yeh <kevinyeah@utexas.edu> | 2015-11-19 14:23:56 -0600 |
| commit | 22837b07483c91f8fbda2bd1df3e2bb83af5c48d (patch) | |
| tree | 4828fa58b7ecede1fb27b9e08adb483e9bcff26a /src | |
| parent | 4d7de5a16e230d8cf533c1cafee574862f06b968 (diff) | |
Combine block utilities
Diffstat (limited to 'src')
| -rw-r--r-- | src/expr.rs | 21 | ||||
| -rw-r--r-- | src/items.rs | 26 |
2 files changed, 24 insertions, 23 deletions
diff --git a/src/expr.rs b/src/expr.rs index c4b01e38b42..7616ef0c328 100644 --- a/src/expr.rs +++ b/src/expr.rs @@ -688,6 +688,27 @@ fn is_simple_block(block: &ast::Block, codemap: &CodeMap) -> bool { !contains_comment(&snippet) } +/// Checks whether a block contains at most one statement or expression, and no comments. +pub fn is_simple_block_stmt(block: &ast::Block, codemap: &CodeMap) -> bool { + if (!block.stmts.is_empty() && block.expr.is_some()) || + (block.stmts.len() != 1 && block.expr.is_none()) { + return false; + } + + let snippet = codemap.span_to_snippet(block.span).unwrap(); + !contains_comment(&snippet) +} + +/// Checks whether a block contains no statements, expressions, or comments. +pub fn is_empty_block(block: &ast::Block, codemap: &CodeMap) -> bool { + if !block.stmts.is_empty() || block.expr.is_some() { + return false; + } + + let snippet = codemap.span_to_snippet(block.span).unwrap(); + !contains_comment(&snippet) +} + // inter-match-arm-comment-rules: // - all comments following a match arm before the start of the next arm // are about the second arm diff --git a/src/items.rs b/src/items.rs index 58ddea0c483..f16f5b50e6d 100644 --- a/src/items.rs +++ b/src/items.rs @@ -15,14 +15,14 @@ use utils::{format_mutability, format_visibility, contains_skip, span_after, end wrap_str, last_line_width, semicolon_for_expr, semicolon_for_stmt}; use lists::{write_list, itemize_list, ListItem, ListFormatting, SeparatorTactic, DefinitiveListTactic, definitive_tactic, format_item_list}; -use expr::rewrite_assign_rhs; -use comment::{FindUncommented, contains_comment}; +use expr::{is_empty_block, is_simple_block_stmt, rewrite_assign_rhs}; +use comment::FindUncommented; use visitor::FmtVisitor; use rewrite::{Rewrite, RewriteContext}; use config::{Config, BlockIndentStyle, Density, ReturnIndent, BraceStyle, StructLitStyle}; use syntax::{ast, abi}; -use syntax::codemap::{Span, BytePos, CodeMap, mk_sp}; +use syntax::codemap::{Span, BytePos, mk_sp}; use syntax::print::pprust; use syntax::parse::token; @@ -1392,23 +1392,3 @@ fn span_for_where_pred(pred: &ast::WherePredicate) -> Span { ast::WherePredicate::EqPredicate(ref p) => p.span, } } - -// Checks whether a block contains at most one statement or expression, and no comments. -fn is_simple_block_stmt(block: &ast::Block, codemap: &CodeMap) -> bool { - if (!block.stmts.is_empty() && block.expr.is_some()) || - (block.stmts.len() != 1 && block.expr.is_none()) { - return false; - } - - let snippet = codemap.span_to_snippet(block.span).unwrap(); - !contains_comment(&snippet) -} - -fn is_empty_block(block: &ast::Block, codemap: &CodeMap) -> bool { - if !block.stmts.is_empty() || block.expr.is_some() { - return false; - } - - let snippet = codemap.span_to_snippet(block.span).unwrap(); - !contains_comment(&snippet) -} |
