diff options
| author | Joshua Nelson <jyn514@gmail.com> | 2021-06-05 12:47:10 -0400 |
|---|---|---|
| committer | Joshua Nelson <jyn514@gmail.com> | 2021-06-05 12:47:10 -0400 |
| commit | 2fbe2ca916e4a815a15c5100bc5ad1452d33a314 (patch) | |
| tree | fce88e0a3b0b6bc123ff56a12aa76b13f6970185 /src | |
| parent | 28d0d0c38b791bf60a83b34e7bb3eec165a2734c (diff) | |
| download | rust-2fbe2ca916e4a815a15c5100bc5ad1452d33a314.tar.gz rust-2fbe2ca916e4a815a15c5100bc5ad1452d33a314.zip | |
Simplify commit check
Diffstat (limited to 'src')
| -rw-r--r-- | src/bootstrap/native.rs | 37 |
1 files changed, 15 insertions, 22 deletions
diff --git a/src/bootstrap/native.rs b/src/bootstrap/native.rs index 3a5ef3e308b..7632889689f 100644 --- a/src/bootstrap/native.rs +++ b/src/bootstrap/native.rs @@ -107,33 +107,26 @@ pub(crate) fn update_llvm_submodule(build: &Build) { } // check_submodule - let buf; - let checked_out = if build.config.fast_submodules { - buf = output( + if build.config.fast_submodules { + let checked_out_hash = output( Command::new("git") .args(&["rev-parse", "HEAD"]) .current_dir(build.config.src.join(llvm_project)), ); - Some(buf.trim_end()) - } else { - None - }; + // update_submodules + let recorded = output( + Command::new("git") + .args(&["ls-tree", "HEAD"]) + .arg(llvm_project) + .current_dir(&build.config.src), + ); + let actual_hash = recorded + .split_whitespace() + .nth(2) + .unwrap_or_else(|| panic!("unexpected output `{}`", recorded)); - // update_submodules - let recorded = output( - Command::new("git") - .args(&["ls-tree", "HEAD"]) - .arg(llvm_project) - .current_dir(&build.config.src), - ); - let hash = recorded - .split_whitespace() - .nth(2) - .unwrap_or_else(|| panic!("unexpected output `{}`", recorded)); - - // update_submodule - if let Some(llvm_hash) = checked_out { - if hash == llvm_hash { + // update_submodule + if actual_hash == checked_out_hash.trim_end() { // already checked out return; } |
