diff options
| author | Mazdak Farrokhzad <twingoow@gmail.com> | 2019-07-06 22:14:38 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-07-06 22:14:38 +0200 |
| commit | 30e4a874cb31a55294d80ee3eda3d41bf8a8ec8f (patch) | |
| tree | 361480d66747a8fe02e16b8eead77809b230b9eb /src | |
| parent | 154726cf7d92e72e3386e056cf0ec61902f342cd (diff) | |
| parent | 7646d4935b50c02f97545705af46ab46116db91d (diff) | |
| download | rust-30e4a874cb31a55294d80ee3eda3d41bf8a8ec8f.tar.gz rust-30e4a874cb31a55294d80ee3eda3d41bf8a8ec8f.zip | |
Rollup merge of #62422 - lzutao:remove-some-mem-uinit, r=alexcrichton
Remove some uses of mem::uninitialized cc #62397 r? @RalfJung
Diffstat (limited to 'src')
| -rw-r--r-- | src/librustc_codegen_llvm/common.rs | 3 | ||||
| -rw-r--r-- | src/libterm/win.rs | 38 |
2 files changed, 30 insertions, 11 deletions
diff --git a/src/librustc_codegen_llvm/common.rs b/src/librustc_codegen_llvm/common.rs index 9fdc93c3ff0..3b2701b893b 100644 --- a/src/librustc_codegen_llvm/common.rs +++ b/src/librustc_codegen_llvm/common.rs @@ -170,8 +170,7 @@ impl CodegenCx<'ll, 'tcx> { pub fn const_get_real(&self, v: &'ll Value) -> Option<(f64, bool)> { unsafe { if self.is_const_real(v) { - #[allow(deprecated)] - let mut loses_info: llvm::Bool = ::std::mem::uninitialized(); + let mut loses_info: llvm::Bool = 0; let r = llvm::LLVMConstRealGetDouble(v, &mut loses_info); let loses_info = if loses_info == 1 { true } else { false }; Some((r, loses_info)) diff --git a/src/libterm/win.rs b/src/libterm/win.rs index 14ea68d3788..e5911de8396 100644 --- a/src/libterm/win.rs +++ b/src/libterm/win.rs @@ -2,8 +2,6 @@ // FIXME (#13400): this is only a tiny fraction of the Windows console api -extern crate libc; - use std::io; use std::io::prelude::*; @@ -20,6 +18,7 @@ pub struct WinConsole<T> { background: color::Color, } +type SHORT = i16; type WORD = u16; type DWORD = u32; type BOOL = i32; @@ -27,12 +26,28 @@ type HANDLE = *mut u8; #[allow(non_snake_case)] #[repr(C)] +struct SMALL_RECT { + Left: SHORT, + Top: SHORT, + Right: SHORT, + Bottom: SHORT, +} + +#[allow(non_snake_case)] +#[repr(C)] +struct COORD { + X: SHORT, + Y: SHORT, +} + +#[allow(non_snake_case)] +#[repr(C)] struct CONSOLE_SCREEN_BUFFER_INFO { - dwSize: [libc::c_short; 2], - dwCursorPosition: [libc::c_short; 2], + dwSize: COORD, + dwCursorPosition: COORD, wAttributes: WORD, - srWindow: [libc::c_short; 4], - dwMaximumWindowSize: [libc::c_short; 2], + srWindow: SMALL_RECT, + dwMaximumWindowSize: COORD, } #[allow(non_snake_case)] @@ -105,12 +120,17 @@ impl<T: Write + Send + 'static> WinConsole<T> { /// Returns `None` whenever the terminal cannot be created for some reason. pub fn new(out: T) -> io::Result<WinConsole<T>> { + use std::mem::MaybeUninit; + let fg; let bg; unsafe { - #[allow(deprecated)] - let mut buffer_info = ::std::mem::uninitialized(); - if GetConsoleScreenBufferInfo(GetStdHandle(-11i32 as DWORD), &mut buffer_info) != 0 { + let mut buffer_info = MaybeUninit::<CONSOLE_SCREEN_BUFFER_INFO>::uninit(); + if GetConsoleScreenBufferInfo( + GetStdHandle(-11i32 as DWORD), + buffer_info.as_mut_ptr() + ) != 0 { + let buffer_info = buffer_info.assume_init() ; fg = bits_to_color(buffer_info.wAttributes); bg = bits_to_color(buffer_info.wAttributes >> 4); } else { |
