diff options
| author | bors <bors@rust-lang.org> | 2025-03-11 12:05:16 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2025-03-11 12:05:16 +0000 |
| commit | 5a44fffc336cf4cdc1c54386ea3f048254c51eef (patch) | |
| tree | 18485524af380b40cf026f8d8a0836671cd0c37d /src | |
| parent | 540565e5b97b4669cd84ecd57f3d7affd00e83a1 (diff) | |
| parent | 157137a64aeba7fb6e6571bcc046c97d63d368a7 (diff) | |
| download | rust-5a44fffc336cf4cdc1c54386ea3f048254c51eef.tar.gz rust-5a44fffc336cf4cdc1c54386ea3f048254c51eef.zip | |
Auto merge of #137586 - nnethercote:SetImpliedBits, r=bjorn3
Speed up target feature computation The LLVM backend calls `LLVMRustHasFeature` twice for every feature. In short-running rustc invocations, this accounts for a surprising amount of work. r? `@bjorn3`
Diffstat (limited to 'src')
| -rw-r--r-- | src/lib.rs | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/src/lib.rs b/src/lib.rs index a3f43744875..06939beb374 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -176,13 +176,9 @@ impl CodegenBackend for CraneliftCodegenBackend { } } - fn target_features_cfg( - &self, - sess: &Session, - _allow_unstable: bool, - ) -> Vec<rustc_span::Symbol> { + fn target_features_cfg(&self, sess: &Session) -> (Vec<Symbol>, Vec<Symbol>) { // FIXME return the actually used target features. this is necessary for #[cfg(target_feature)] - if sess.target.arch == "x86_64" && sess.target.os != "none" { + let target_features = if sess.target.arch == "x86_64" && sess.target.os != "none" { // x86_64 mandates SSE2 support and rustc requires the x87 feature to be enabled vec![sym::fsxr, sym::sse, sym::sse2, Symbol::intern("x87")] } else if sess.target.arch == "aarch64" { @@ -196,7 +192,10 @@ impl CodegenBackend for CraneliftCodegenBackend { } } else { vec![] - } + }; + // FIXME do `unstable_target_features` properly + let unstable_target_features = target_features.clone(); + (target_features, unstable_target_features) } fn print_version(&self) { |
