about summary refs log tree commit diff
path: root/src
diff options
context:
space:
mode:
authorMark Simulacrum <mark.simulacrum@gmail.com>2017-05-19 14:16:25 -0600
committerGitHub <noreply@github.com>2017-05-19 14:16:25 -0600
commit5ded76ca214a9786582e5dd0cb81408006daeef3 (patch)
treebc92a59cbb9bed7aae7b95e12ff00854339f66df /src
parentfd8ca3ea6d9dbd09336f882ec9a2952a752954b5 (diff)
parente48086c04fb8092253ab638c6b0aa82b09edc8d0 (diff)
downloadrust-5ded76ca214a9786582e5dd0cb81408006daeef3.tar.gz
rust-5ded76ca214a9786582e5dd0cb81408006daeef3.zip
Rollup merge of #42096 - ollie27:rustdoc_js_impls, r=GuillaumeGomez
rustdoc: Fix implementors list javascript

* Use a different loop variable, `i` was already taken. This caused
missing items in the implementors list.
* Use `.getAttribute('href')` rather than `.href` to get the relative
URL which is what it needs to actually fix the links.

More fallout from #41307.

r? @GuillaumeGomez
Diffstat (limited to 'src')
-rw-r--r--src/librustdoc/html/static/main.js6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/librustdoc/html/static/main.js b/src/librustdoc/html/static/main.js
index f09ce1cc648..53e341226af 100644
--- a/src/librustdoc/html/static/main.js
+++ b/src/librustdoc/html/static/main.js
@@ -1083,10 +1083,10 @@
                 code.innerHTML = structs[j];
 
                 var x = code.getElementsByTagName('a');
-                for (var i = 0; i < x.length; i++) {
-                    var href = x[i].href;
+                for (var k = 0; k < x.length; k++) {
+                    var href = x[k].getAttribute('href');
                     if (href && href.indexOf('http') !== 0) {
-                        x[i].href = rootPath + href;
+                        x[k].setAttribute('href', rootPath + href);
                     }
                 }
                 var li = document.createElement('li');