about summary refs log tree commit diff
path: root/src
diff options
context:
space:
mode:
authorYuki Okushi <jtitor@2k36.org>2022-05-17 19:01:32 +0900
committerGitHub <noreply@github.com>2022-05-17 19:01:32 +0900
commit70cd85f5e39e04ba1b553784440481530606043c (patch)
tree3f0a4c74262efc14ca6e29ce8d33047a0a43c2e6 /src
parentaaa0c014e2a9920e1a8aa30f7a6cec46cc7691fe (diff)
parent38bf1158bd850c80de42599c28602ae11727a133 (diff)
downloadrust-70cd85f5e39e04ba1b553784440481530606043c.tar.gz
rust-70cd85f5e39e04ba1b553784440481530606043c.zip
Rollup merge of #97079 - SparrowLii:successors, r=lcnr
Change `Successors` to `impl Iterator<Item = BasicBlock>`

This PR fixes the FIXME in `compiler\rustc_middle\src\mir\mod.rs`.
This can omit several `&`, `*` or `cloned` operations on Successros' generated elements
Diffstat (limited to 'src')
-rw-r--r--src/tools/clippy/clippy_lints/src/redundant_clone.rs4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/tools/clippy/clippy_lints/src/redundant_clone.rs b/src/tools/clippy/clippy_lints/src/redundant_clone.rs
index 1507c75ff61..37aac8b2a49 100644
--- a/src/tools/clippy/clippy_lints/src/redundant_clone.rs
+++ b/src/tools/clippy/clippy_lints/src/redundant_clone.rs
@@ -114,7 +114,7 @@ impl<'tcx> LateLintPass<'tcx> for RedundantClone {
             }
 
             // Give up on loops
-            if terminator.successors().any(|s| *s == bb) {
+            if terminator.successors().any(|s| s == bb) {
                 continue;
             }
 
@@ -440,7 +440,7 @@ fn visit_clone_usage(cloned: mir::Local, clone: mir::Local, mir: &mir::Body<'_>,
             // Short-circuit
             if (usage.cloned_used && usage.clone_consumed_or_mutated) ||
                 // Give up on loops
-                tdata.terminator().successors().any(|s| *s == bb)
+                tdata.terminator().successors().any(|s| s == bb)
             {
                 return CloneUsage {
                     cloned_used: true,