diff options
| author | est31 <MTest31@outlook.com> | 2022-10-30 04:02:10 +0100 |
|---|---|---|
| committer | est31 <MTest31@outlook.com> | 2022-10-30 05:05:21 +0100 |
| commit | 7b55d17a2f74f5254c7cf948329232c0bffe724c (patch) | |
| tree | 24bc917b9d210923570a3b91a6b56e7f8535c908 /src | |
| parent | 5e9772042948002f9c6f60c4c81603170035fffa (diff) | |
| download | rust-7b55d17a2f74f5254c7cf948329232c0bffe724c.tar.gz rust-7b55d17a2f74f5254c7cf948329232c0bffe724c.zip | |
Reduce span of let else irrefutable_let_patterns warning
Huge spans aren't good for IDE users as they underline constructs that are possibly multiline.
Diffstat (limited to 'src')
| -rw-r--r-- | src/test/ui/let-else/let-else-irrefutable.rs | 8 | ||||
| -rw-r--r-- | src/test/ui/let-else/let-else-irrefutable.stderr | 15 |
2 files changed, 18 insertions, 5 deletions
diff --git a/src/test/ui/let-else/let-else-irrefutable.rs b/src/test/ui/let-else/let-else-irrefutable.rs index 1cb68ecb8a6..f4b338eb0af 100644 --- a/src/test/ui/let-else/let-else-irrefutable.rs +++ b/src/test/ui/let-else/let-else-irrefutable.rs @@ -1,7 +1,11 @@ // check-pass - - fn main() { let x = 1 else { return }; //~ WARN irrefutable `let...else` pattern + + // Multiline else blocks should not get printed + let x = 1 else { //~ WARN irrefutable `let...else` pattern + eprintln!("problem case encountered"); + return + }; } diff --git a/src/test/ui/let-else/let-else-irrefutable.stderr b/src/test/ui/let-else/let-else-irrefutable.stderr index e0581f4d9ab..73d4e5f3483 100644 --- a/src/test/ui/let-else/let-else-irrefutable.stderr +++ b/src/test/ui/let-else/let-else-irrefutable.stderr @@ -1,12 +1,21 @@ warning: irrefutable `let...else` pattern - --> $DIR/let-else-irrefutable.rs:6:5 + --> $DIR/let-else-irrefutable.rs:4:5 | LL | let x = 1 else { return }; - | ^^^^^^^^^^^^^^^^^^^^^^^^^^ + | ^^^^^^^^^ | = note: this pattern will always match, so the `else` clause is useless = help: consider removing the `else` clause = note: `#[warn(irrefutable_let_patterns)]` on by default -warning: 1 warning emitted +warning: irrefutable `let...else` pattern + --> $DIR/let-else-irrefutable.rs:7:5 + | +LL | let x = 1 else { + | ^^^^^^^^^ + | + = note: this pattern will always match, so the `else` clause is useless + = help: consider removing the `else` clause + +warning: 2 warnings emitted |
