diff options
| author | Eric Huss <eric@huss.org> | 2024-12-31 08:50:04 -0800 |
|---|---|---|
| committer | Eric Huss <eric@huss.org> | 2024-12-31 08:50:04 -0800 |
| commit | a6ba04ae6a9f76a0513a3084dfd2a4ebab4b381f (patch) | |
| tree | b114af8b1d9185a6d293f78df37609660ca60047 /src | |
| parent | 3bf62ccc1055a94dfa6a72650b10a71dcf232429 (diff) | |
| download | rust-a6ba04ae6a9f76a0513a3084dfd2a4ebab4b381f.tar.gz rust-a6ba04ae6a9f76a0513a3084dfd2a4ebab4b381f.zip | |
Revert "Rollup merge of #132369 - joshtriplett:style-guide-binop-heuristic-assignment-only, r=calebcartwright"
This reverts commit 348d28052b1717f152b04725492c256c3409a361, reversing changes made to 526c67f37be44688345aec14f7b1c5926f4a59a7.
Diffstat (limited to 'src')
| -rw-r--r-- | src/doc/style-guide/src/editions.md | 5 | ||||
| -rw-r--r-- | src/doc/style-guide/src/expressions.md | 12 |
2 files changed, 11 insertions, 6 deletions
diff --git a/src/doc/style-guide/src/editions.md b/src/doc/style-guide/src/editions.md index d9dba641495..74e873e35ff 100644 --- a/src/doc/style-guide/src/editions.md +++ b/src/doc/style-guide/src/editions.md @@ -40,9 +40,8 @@ include: of a delimited expression, delimited expressions are generally combinable, regardless of the number of members. Previously only applied with exactly one member (except for closures with explicit blocks). -- When line-breaking an assignment operator, if the left-hand side spans - multiple lines, use the base indentation of the last line of the left-hand - side to indent the right-hand side. +- When line-breaking a binary operator, if the first operand spans multiple + lines, use the base indentation of the last line. - Miscellaneous `rustfmt` bugfixes. - Use version-sort (sort `x8`, `x16`, `x32`, `x64`, `x128` in that order). - Change "ASCIIbetical" sort to Unicode-aware "non-lowercase before lowercase". diff --git a/src/doc/style-guide/src/expressions.md b/src/doc/style-guide/src/expressions.md index 4f63a632030..3bb0ee6d5ff 100644 --- a/src/doc/style-guide/src/expressions.md +++ b/src/doc/style-guide/src/expressions.md @@ -328,9 +328,9 @@ foo_bar Prefer line-breaking at an assignment operator (either `=` or `+=`, etc.) rather than at other binary operators. -If line-breaking an assignment operator where the left-hand side spans multiple -lines, use the base indentation of the *last* line of the left-hand side, and -indent the right-hand side relative to that: +If line-breaking at a binary operator (including assignment operators) where the +first operand spans multiple lines, use the base indentation of the *last* +line of the first operand, and indent relative to that: ```rust impl SomeType { @@ -344,6 +344,12 @@ impl SomeType { self.array[array_index as usize] .as_mut() .expect("thing must exist") + .extra_info + + long_long_long_long_long_long_long_long_long_long_long_long_long_long_long; + + self.array[array_index as usize] + .as_mut() + .expect("thing must exist") .extra_info = Some(ExtraInfo { parent, count: count as u16, |
