about summary refs log tree commit diff
path: root/src
diff options
context:
space:
mode:
authorMichael Lamparski <diagonaldevice@gmail.com>2018-04-16 16:34:09 -0400
committerMichael Lamparski <diagonaldevice@gmail.com>2018-04-17 21:31:35 -0400
commitb74d6922ff15d9f3bf39d317ccd7141518f4f5ec (patch)
tree70be92ac0bfff57432121221c5f1a6618de2aa44 /src
parent9a59133c09980122ce026d20e7832d63b106a927 (diff)
downloadrust-b74d6922ff15d9f3bf39d317ccd7141518f4f5ec.tar.gz
rust-b74d6922ff15d9f3bf39d317ccd7141518f4f5ec.zip
smaller PR just to fix #50002
Diffstat (limited to 'src')
-rw-r--r--src/liballoc/tests/str.rs16
-rw-r--r--src/libcore/str/mod.rs9
2 files changed, 18 insertions, 7 deletions
diff --git a/src/liballoc/tests/str.rs b/src/liballoc/tests/str.rs
index a3f4c385fe2..e3f198f7362 100644
--- a/src/liballoc/tests/str.rs
+++ b/src/liballoc/tests/str.rs
@@ -402,6 +402,22 @@ fn test_str_get_maxinclusive() {
 }
 
 #[test]
+fn test_str_slicemut_rangetoinclusive_ok() {
+    let mut s = "abcαβγ".to_owned();
+    let s: &mut str = &mut s;
+    &mut s[..=3]; // before alpha
+    &mut s[..=5]; // after alpha
+}
+
+#[test]
+#[should_panic]
+fn test_str_slicemut_rangetoinclusive_notok() {
+    let mut s = "abcαβγ".to_owned();
+    let s: &mut str = &mut s;
+    &mut s[..=4]; // middle of alpha, which is 2 bytes long
+}
+
+#[test]
 fn test_is_char_boundary() {
     let s = "ศไทย中华Việt Nam β-release 🐱123";
     assert!(s.is_char_boundary(0));
diff --git a/src/libcore/str/mod.rs b/src/libcore/str/mod.rs
index f1fe23092de..5b52119d031 100644
--- a/src/libcore/str/mod.rs
+++ b/src/libcore/str/mod.rs
@@ -2100,18 +2100,13 @@ mod traits {
         fn index(self, slice: &str) -> &Self::Output {
             assert!(self.end != usize::max_value(),
                 "attempted to index str up to maximum usize");
-            let end = self.end + 1;
-            self.get(slice).unwrap_or_else(|| super::slice_error_fail(slice, 0, end))
+            (..self.end+1).index(slice)
         }
         #[inline]
         fn index_mut(self, slice: &mut str) -> &mut Self::Output {
             assert!(self.end != usize::max_value(),
                 "attempted to index str up to maximum usize");
-            if slice.is_char_boundary(self.end) {
-                unsafe { self.get_unchecked_mut(slice) }
-            } else {
-                super::slice_error_fail(slice, 0, self.end + 1)
-            }
+            (..self.end+1).index_mut(slice)
         }
     }