about summary refs log tree commit diff
path: root/src
diff options
context:
space:
mode:
authorfee1-dead <ent3rm4n@gmail.com>2023-01-09 23:35:27 +0800
committerGitHub <noreply@github.com>2023-01-09 23:35:27 +0800
commitc1f8a3ffb2b9b155b400a675727ebd470938805c (patch)
treee301a684ac7a910ba6c7dab3cd9a44e3359a93c9 /src
parentb7587f1867c73f3517d7071bb4989dd7e19540f1 (diff)
parentafefbb66c3abea2e9b3acacddf7516b24c2bbeb8 (diff)
downloadrust-c1f8a3ffb2b9b155b400a675727ebd470938805c.tar.gz
rust-c1f8a3ffb2b9b155b400a675727ebd470938805c.zip
Rollup merge of #105655 - RedDocMD:bug-105645, r=oli-obk
Remove invalid case for mutable borrow suggestion

If we have a call such as `foo(&mut buf)` and after reference
collapsing the type is inferred as `&T` where-as the required type is
`&mut T`, don't suggest `foo(&mut mut buf)`. This is wrong syntactically
and the issue lies elsewhere, not in the borrow.

Fixes #105645
Diffstat (limited to 'src')
-rw-r--r--src/test/ui/suggestions/issue-105645.rs8
-rw-r--r--src/test/ui/suggestions/issue-105645.stderr18
2 files changed, 26 insertions, 0 deletions
diff --git a/src/test/ui/suggestions/issue-105645.rs b/src/test/ui/suggestions/issue-105645.rs
new file mode 100644
index 00000000000..681ce1c6e37
--- /dev/null
+++ b/src/test/ui/suggestions/issue-105645.rs
@@ -0,0 +1,8 @@
+fn main() {
+    let mut buf = [0u8; 50];
+    let mut bref = buf.as_slice();
+    foo(&mut bref);
+    //~^ ERROR 4:9: 4:18: the trait bound `&[u8]: std::io::Write` is not satisfied [E0277]
+}
+
+fn foo(_: &mut impl std::io::Write) {}
diff --git a/src/test/ui/suggestions/issue-105645.stderr b/src/test/ui/suggestions/issue-105645.stderr
new file mode 100644
index 00000000000..895f5ffd1e1
--- /dev/null
+++ b/src/test/ui/suggestions/issue-105645.stderr
@@ -0,0 +1,18 @@
+error[E0277]: the trait bound `&[u8]: std::io::Write` is not satisfied
+  --> $DIR/issue-105645.rs:4:9
+   |
+LL |     foo(&mut bref);
+   |     --- ^^^^^^^^^ the trait `std::io::Write` is not implemented for `&[u8]`
+   |     |
+   |     required by a bound introduced by this call
+   |
+   = help: the trait `std::io::Write` is implemented for `&mut [u8]`
+note: required by a bound in `foo`
+  --> $DIR/issue-105645.rs:8:21
+   |
+LL | fn foo(_: &mut impl std::io::Write) {}
+   |                     ^^^^^^^^^^^^^^ required by this bound in `foo`
+
+error: aborting due to previous error
+
+For more information about this error, try `rustc --explain E0277`.