diff options
| author | Daniel Micay <danielmicay@gmail.com> | 2013-06-17 16:37:11 -0400 |
|---|---|---|
| committer | Daniel Micay <danielmicay@gmail.com> | 2013-06-21 03:20:22 -0400 |
| commit | cbad1da3db7eda0911e988fb6255ac5c16961aa7 (patch) | |
| tree | 29f09c6f808aed451acb27146f3f895a310b41fa /src | |
| parent | 62dc4e0d4cebc390de4053da881a74b9e72c52e6 (diff) | |
| download | rust-cbad1da3db7eda0911e988fb6255ac5c16961aa7.tar.gz rust-cbad1da3db7eda0911e988fb6255ac5c16961aa7.zip | |
vec: remove eachi
replaced by the `enumerate` method from std::iterator
Diffstat (limited to 'src')
| -rw-r--r-- | src/compiletest/runtest.rs | 2 | ||||
| -rw-r--r-- | src/librustc/middle/trans/cabi.rs | 4 | ||||
| -rw-r--r-- | src/librustc/middle/trans/closure.rs | 2 | ||||
| -rw-r--r-- | src/librustc/middle/trans/glue.rs | 2 | ||||
| -rw-r--r-- | src/libstd/vec.rs | 41 | ||||
| -rw-r--r-- | src/test/bench/shootout-chameneos-redux.rs | 14 |
6 files changed, 12 insertions, 53 deletions
diff --git a/src/compiletest/runtest.rs b/src/compiletest/runtest.rs index e0ceb79a37d..71146c7e665 100644 --- a/src/compiletest/runtest.rs +++ b/src/compiletest/runtest.rs @@ -358,7 +358,7 @@ fn check_expected_errors(expected_errors: ~[errors::ExpectedError], // is the ending point, and * represents ANSI color codes. for ProcRes.stderr.line_iter().advance |line| { let mut was_expected = false; - for vec::eachi(expected_errors) |i, ee| { + for expected_errors.iter().enumerate().advance |(i, ee)| { if !found_flags[i] { debug!("prefix=%s ee.kind=%s ee.msg=%s line=%s", prefixes[i], ee.kind, ee.msg, line); diff --git a/src/librustc/middle/trans/cabi.rs b/src/librustc/middle/trans/cabi.rs index acc3293f267..891eb0b1f1c 100644 --- a/src/librustc/middle/trans/cabi.rs +++ b/src/librustc/middle/trans/cabi.rs @@ -43,7 +43,7 @@ impl FnType { let fnty = T_fn(atys, rty); let llfn = decl(fnty); - for vec::eachi(self.attrs) |i, a| { + for self.attrs.iter().enumerate().advance |(i, a)| { match *a { option::Some(attr) => { unsafe { @@ -100,7 +100,7 @@ impl FnType { ret_def: bool, llargbundle: ValueRef, llretval: ValueRef) { - for vec::eachi(self.attrs) |i, a| { + for self.attrs.iter().enumerate().advance |(i, a)| { match *a { option::Some(attr) => { unsafe { diff --git a/src/librustc/middle/trans/closure.rs b/src/librustc/middle/trans/closure.rs index c368ab5c9bd..8bc3889eb11 100644 --- a/src/librustc/middle/trans/closure.rs +++ b/src/librustc/middle/trans/closure.rs @@ -225,7 +225,7 @@ pub fn store_environment(bcx: block, // Copy expr values into boxed bindings. let mut bcx = bcx; - for vec::eachi(bound_values) |i, bv| { + for bound_values.iter().enumerate().advance |(i, bv)| { debug!("Copy %s into closure", bv.to_str(ccx)); if ccx.sess.asm_comments() { diff --git a/src/librustc/middle/trans/glue.rs b/src/librustc/middle/trans/glue.rs index 05461c93631..0ea63dde972 100644 --- a/src/librustc/middle/trans/glue.rs +++ b/src/librustc/middle/trans/glue.rs @@ -462,7 +462,7 @@ pub fn trans_struct_drop(bcx: block, // Drop the fields let field_tys = ty::struct_fields(bcx.tcx(), class_did, substs); - for vec::eachi(field_tys) |i, fld| { + for field_tys.iter().enumerate().advance |(i, fld)| { let llfld_a = adt::trans_field_ptr(bcx, repr, v0, 0, i); bcx = drop_ty(bcx, llfld_a, fld.mt.ty); } diff --git a/src/libstd/vec.rs b/src/libstd/vec.rs index 1131abfafa8..0d5a84a4a76 100644 --- a/src/libstd/vec.rs +++ b/src/libstd/vec.rs @@ -1428,21 +1428,6 @@ pub fn each<'r,T>(v: &'r [T], f: &fn(&'r T) -> bool) -> bool { } /** - * Iterates over a vector's elements and indices - * - * Return true to continue, false to break. - */ -#[inline] -pub fn eachi<'r,T>(v: &'r [T], f: &fn(uint, v: &'r T) -> bool) -> bool { - let mut i = 0; - for each(v) |p| { - if !f(i, p) { return false; } - i += 1; - } - return true; -} - -/** * Iterate over all permutations of vector `v`. * * Permutations are produced in lexicographic order with respect to the order @@ -3260,17 +3245,6 @@ mod tests { } #[test] - fn test_eachi() { - let mut i = 0; - for eachi([1, 2, 3]) |j, v| { - if i == 0 { assert!(*v == 1); } - assert_eq!(j + 1u, *v as uint); - i += *v; - } - assert_eq!(i, 6); - } - - #[test] fn test_each_ret_len0() { let a0 : [int, .. 0] = []; assert_eq!(each(a0, |_p| fail!()), true); @@ -4114,21 +4088,6 @@ mod tests { #[test] #[ignore(windows)] #[should_fail] - fn test_eachi_fail() { - let v = [(~0, @0), (~0, @0), (~0, @0), (~0, @0)]; - let mut i = 0; - do eachi(v) |_i, _elt| { - if i == 2 { - fail!() - } - i += 0; - false - }; - } - - #[test] - #[ignore(windows)] - #[should_fail] #[allow(non_implicitly_copyable_typarams)] fn test_permute_fail() { let v = [(~0, @0), (~0, @0), (~0, @0), (~0, @0)]; diff --git a/src/test/bench/shootout-chameneos-redux.rs b/src/test/bench/shootout-chameneos-redux.rs index 53b47b12144..2a9ea783c14 100644 --- a/src/test/bench/shootout-chameneos-redux.rs +++ b/src/test/bench/shootout-chameneos-redux.rs @@ -23,11 +23,11 @@ use std::uint; use std::vec; fn print_complements() { - let all = ~[Blue, Red, Yellow]; - for vec::each(all) |aa| { - for vec::each(all) |bb| { - io::println(show_color(*aa) + " + " + show_color(*bb) + - " -> " + show_color(transform(*aa, *bb))); + let all = [Blue, Red, Yellow]; + for all.iter().advance |aa| { + for all.iter().advance |bb| { + println(show_color(*aa) + " + " + show_color(*bb) + + " -> " + show_color(transform(*aa, *bb))); } } } @@ -49,7 +49,7 @@ fn show_color(cc: color) -> ~str { fn show_color_list(set: ~[color]) -> ~str { let mut out = ~""; - for vec::eachi(set) |_ii, col| { + for set.iter().advance |col| { out += " "; out += show_color(*col); } @@ -182,7 +182,7 @@ fn rendezvous(nn: uint, set: ~[color]) { } // tell each creature to stop - for vec::eachi(to_creature) |_ii, to_one| { + for to_creature.iter().advance |to_one| { to_one.send(None); } |
