diff options
| author | bors <bors@rust-lang.org> | 2019-08-04 20:03:28 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2019-08-04 20:03:28 +0000 |
| commit | d3f8a0b5dfddfe443d9db1f1da18348dbceb0e47 (patch) | |
| tree | d878818a562a332fbb4f63b954c69bcb0621c72d /src | |
| parent | f01b9f803b59f170f5dabaaa8aedc96abe45bfea (diff) | |
| parent | fd819d02d7bf4f93d0b06849b9f0984a85281956 (diff) | |
| download | rust-d3f8a0b5dfddfe443d9db1f1da18348dbceb0e47.tar.gz rust-d3f8a0b5dfddfe443d9db1f1da18348dbceb0e47.zip | |
Auto merge of #63213 - varkor:itemkind-tyalias, r=Centril
Rename `ItemKind::Ty` to `ItemKind::TyAlias` The current name is not entirely clear without context and `TyAlias` is consistent with `ItemKind::TraitAlias`.
Diffstat (limited to 'src')
36 files changed, 90 insertions, 89 deletions
diff --git a/src/librustc/hir/check_attr.rs b/src/librustc/hir/check_attr.rs index db90e44b892..22124d4ee41 100644 --- a/src/librustc/hir/check_attr.rs +++ b/src/librustc/hir/check_attr.rs @@ -26,7 +26,7 @@ pub(crate) enum Target { Mod, ForeignMod, GlobalAsm, - Ty, + TyAlias, OpaqueTy, Enum, Struct, @@ -50,7 +50,7 @@ impl Display for Target { Target::Mod => "module", Target::ForeignMod => "foreign module", Target::GlobalAsm => "global asm", - Target::Ty => "type alias", + Target::TyAlias => "type alias", Target::OpaqueTy => "opaque type", Target::Enum => "enum", Target::Struct => "struct", @@ -75,7 +75,7 @@ impl Target { hir::ItemKind::Mod(..) => Target::Mod, hir::ItemKind::ForeignMod(..) => Target::ForeignMod, hir::ItemKind::GlobalAsm(..) => Target::GlobalAsm, - hir::ItemKind::Ty(..) => Target::Ty, + hir::ItemKind::TyAlias(..) => Target::TyAlias, hir::ItemKind::OpaqueTy(..) => Target::OpaqueTy, hir::ItemKind::Enum(..) => Target::Enum, hir::ItemKind::Struct(..) => Target::Struct, diff --git a/src/librustc/hir/intravisit.rs b/src/librustc/hir/intravisit.rs index 625e746c24f..b5c760bc9a0 100644 --- a/src/librustc/hir/intravisit.rs +++ b/src/librustc/hir/intravisit.rs @@ -500,7 +500,7 @@ pub fn walk_item<'v, V: Visitor<'v>>(visitor: &mut V, item: &'v Item) { ItemKind::GlobalAsm(_) => { visitor.visit_id(item.hir_id); } - ItemKind::Ty(ref ty, ref generics) => { + ItemKind::TyAlias(ref ty, ref generics) => { visitor.visit_id(item.hir_id); visitor.visit_ty(ty); visitor.visit_generics(generics) @@ -926,7 +926,7 @@ pub fn walk_impl_item<'v, V: Visitor<'v>>(visitor: &mut V, impl_item: &'v ImplIt impl_item.span, impl_item.hir_id); } - ImplItemKind::Type(ref ty) => { + ImplItemKind::TyAlias(ref ty) => { visitor.visit_id(impl_item.hir_id); visitor.visit_ty(ty); } diff --git a/src/librustc/hir/lowering.rs b/src/librustc/hir/lowering.rs index f76de96cd10..429eb6b3102 100644 --- a/src/librustc/hir/lowering.rs +++ b/src/librustc/hir/lowering.rs @@ -486,7 +486,7 @@ impl<'a> LoweringContext<'a> { ItemKind::Struct(_, ref generics) | ItemKind::Union(_, ref generics) | ItemKind::Enum(_, ref generics) - | ItemKind::Ty(_, ref generics) + | ItemKind::TyAlias(_, ref generics) | ItemKind::OpaqueTy(_, ref generics) | ItemKind::Trait(_, _, ref generics, ..) => { let def_id = self.lctx.resolver.definitions().local_def_id(item.id); @@ -3440,7 +3440,7 @@ impl<'a> LoweringContext<'a> { ItemKind::Mod(ref m) => hir::ItemKind::Mod(self.lower_mod(m)), ItemKind::ForeignMod(ref nm) => hir::ItemKind::ForeignMod(self.lower_foreign_mod(nm)), ItemKind::GlobalAsm(ref ga) => hir::ItemKind::GlobalAsm(self.lower_global_asm(ga)), - ItemKind::Ty(ref t, ref generics) => hir::ItemKind::Ty( + ItemKind::TyAlias(ref t, ref generics) => hir::ItemKind::TyAlias( self.lower_ty(t, ImplTraitContext::disallowed()), self.lower_generics(generics, ImplTraitContext::disallowed()), ), @@ -3914,9 +3914,9 @@ impl<'a> LoweringContext<'a> { (generics, hir::ImplItemKind::Method(sig, body_id)) } - ImplItemKind::Type(ref ty) => ( + ImplItemKind::TyAlias(ref ty) => ( self.lower_generics(&i.generics, ImplTraitContext::disallowed()), - hir::ImplItemKind::Type(self.lower_ty(ty, ImplTraitContext::disallowed())), + hir::ImplItemKind::TyAlias(self.lower_ty(ty, ImplTraitContext::disallowed())), ), ImplItemKind::OpaqueTy(ref bounds) => ( self.lower_generics(&i.generics, ImplTraitContext::disallowed()), @@ -3950,7 +3950,7 @@ impl<'a> LoweringContext<'a> { defaultness: self.lower_defaultness(i.defaultness, true /* [1] */), kind: match i.node { ImplItemKind::Const(..) => hir::AssocItemKind::Const, - ImplItemKind::Type(..) => hir::AssocItemKind::Type, + ImplItemKind::TyAlias(..) => hir::AssocItemKind::Type, ImplItemKind::OpaqueTy(..) => hir::AssocItemKind::OpaqueTy, ImplItemKind::Method(ref sig, _) => hir::AssocItemKind::Method { has_self: sig.decl.has_self(), diff --git a/src/librustc/hir/map/def_collector.rs b/src/librustc/hir/map/def_collector.rs index c44942a1626..2964b130ddd 100644 --- a/src/librustc/hir/map/def_collector.rs +++ b/src/librustc/hir/map/def_collector.rs @@ -93,7 +93,7 @@ impl<'a> visit::Visitor<'a> for DefCollector<'a> { ItemKind::Mod(..) | ItemKind::Trait(..) | ItemKind::TraitAlias(..) | ItemKind::Enum(..) | ItemKind::Struct(..) | ItemKind::Union(..) | ItemKind::OpaqueTy(..) | ItemKind::ExternCrate(..) | ItemKind::ForeignMod(..) | - ItemKind::Ty(..) => DefPathData::TypeNs(i.ident.as_interned_str()), + ItemKind::TyAlias(..) => DefPathData::TypeNs(i.ident.as_interned_str()), ItemKind::Fn( ref decl, ref header, @@ -222,7 +222,7 @@ impl<'a> visit::Visitor<'a> for DefCollector<'a> { } ImplItemKind::Method(..) | ImplItemKind::Const(..) => DefPathData::ValueNs(ii.ident.as_interned_str()), - ImplItemKind::Type(..) | + ImplItemKind::TyAlias(..) | ImplItemKind::OpaqueTy(..) => { DefPathData::TypeNs(ii.ident.as_interned_str()) }, diff --git a/src/librustc/hir/map/mod.rs b/src/librustc/hir/map/mod.rs index b93961a1239..0d477ae7968 100644 --- a/src/librustc/hir/map/mod.rs +++ b/src/librustc/hir/map/mod.rs @@ -302,7 +302,7 @@ impl<'hir> Map<'hir> { ItemKind::Fn(..) => DefKind::Fn, ItemKind::Mod(..) => DefKind::Mod, ItemKind::OpaqueTy(..) => DefKind::OpaqueTy, - ItemKind::Ty(..) => DefKind::TyAlias, + ItemKind::TyAlias(..) => DefKind::TyAlias, ItemKind::Enum(..) => DefKind::Enum, ItemKind::Struct(..) => DefKind::Struct, ItemKind::Union(..) => DefKind::Union, @@ -333,7 +333,7 @@ impl<'hir> Map<'hir> { match item.node { ImplItemKind::Const(..) => DefKind::AssocConst, ImplItemKind::Method(..) => DefKind::Method, - ImplItemKind::Type(..) => DefKind::AssocTy, + ImplItemKind::TyAlias(..) => DefKind::AssocTy, ImplItemKind::OpaqueTy(..) => DefKind::AssocOpaqueTy, } } @@ -576,7 +576,7 @@ impl<'hir> Map<'hir> { Node::Item(ref item) => { match item.node { ItemKind::Fn(_, _, ref generics, _) | - ItemKind::Ty(_, ref generics) | + ItemKind::TyAlias(_, ref generics) | ItemKind::Enum(_, ref generics) | ItemKind::Struct(_, ref generics) | ItemKind::Union(_, ref generics) | @@ -1269,7 +1269,7 @@ fn hir_id_to_string(map: &Map<'_>, id: HirId, include_id: bool) -> String { ItemKind::Mod(..) => "mod", ItemKind::ForeignMod(..) => "foreign mod", ItemKind::GlobalAsm(..) => "global asm", - ItemKind::Ty(..) => "ty", + ItemKind::TyAlias(..) => "ty", ItemKind::OpaqueTy(..) => "opaque type", ItemKind::Enum(..) => "enum", ItemKind::Struct(..) => "struct", @@ -1291,7 +1291,7 @@ fn hir_id_to_string(map: &Map<'_>, id: HirId, include_id: bool) -> String { ImplItemKind::Method(..) => { format!("method {} in {}{}", ii.ident, path_str(), id_str) } - ImplItemKind::Type(_) => { + ImplItemKind::TyAlias(_) => { format!("assoc type {} in {}{}", ii.ident, path_str(), id_str) } ImplItemKind::OpaqueTy(_) => { diff --git a/src/librustc/hir/mod.rs b/src/librustc/hir/mod.rs index 5fe8069e332..b8d8394a02c 100644 --- a/src/librustc/hir/mod.rs +++ b/src/librustc/hir/mod.rs @@ -1837,7 +1837,7 @@ pub enum ImplItemKind { /// A method implementation with the given signature and body. Method(MethodSig, BodyId), /// An associated type. - Type(P<Ty>), + TyAlias(P<Ty>), /// An associated `type = impl Trait`. OpaqueTy(GenericBounds), } @@ -2420,7 +2420,7 @@ pub enum ItemKind { /// Module-level inline assembly (from global_asm!) GlobalAsm(P<GlobalAsm>), /// A type alias, e.g., `type Foo = Bar<u8>` - Ty(P<Ty>, Generics), + TyAlias(P<Ty>, Generics), /// An opaque `impl Trait` type alias, e.g., `type Foo = impl Bar;` OpaqueTy(OpaqueTy), /// An enum definition, e.g., `enum Foo<A, B> {C<A>, D<B>}` @@ -2455,7 +2455,7 @@ impl ItemKind { ItemKind::Mod(..) => "module", ItemKind::ForeignMod(..) => "foreign module", ItemKind::GlobalAsm(..) => "global asm", - ItemKind::Ty(..) => "type alias", + ItemKind::TyAlias(..) => "type alias", ItemKind::OpaqueTy(..) => "opaque type", ItemKind::Enum(..) => "enum", ItemKind::Struct(..) => "struct", @@ -2478,7 +2478,7 @@ impl ItemKind { pub fn generics(&self) -> Option<&Generics> { Some(match *self { ItemKind::Fn(_, _, ref generics, _) | - ItemKind::Ty(_, ref generics) | + ItemKind::TyAlias(_, ref generics) | ItemKind::OpaqueTy(OpaqueTy { ref generics, impl_trait_fn: None, .. }) | ItemKind::Enum(_, ref generics) | ItemKind::Struct(_, ref generics) | diff --git a/src/librustc/hir/print.rs b/src/librustc/hir/print.rs index a8760438fc0..11ba5120530 100644 --- a/src/librustc/hir/print.rs +++ b/src/librustc/hir/print.rs @@ -570,7 +570,7 @@ impl<'a> State<'a> { self.s.word(ga.asm.as_str().to_string()); self.end() } - hir::ItemKind::Ty(ref ty, ref generics) => { + hir::ItemKind::TyAlias(ref ty, ref generics) => { self.print_item_type(item, &generics, |state| { state.word_space("="); state.print_type(&ty); @@ -908,7 +908,7 @@ impl<'a> State<'a> { self.end(); // need to close a box self.ann.nested(self, Nested::Body(body)); } - hir::ImplItemKind::Type(ref ty) => { + hir::ImplItemKind::TyAlias(ref ty) => { self.print_associated_type(ii.ident, None, Some(ty)); } hir::ImplItemKind::OpaqueTy(ref bounds) => { diff --git a/src/librustc/infer/error_reporting/mod.rs b/src/librustc/infer/error_reporting/mod.rs index f92e0336244..8d0ead5c8fe 100644 --- a/src/librustc/infer/error_reporting/mod.rs +++ b/src/librustc/infer/error_reporting/mod.rs @@ -270,7 +270,7 @@ impl<'tcx> TyCtxt<'tcx> { hir::ImplItemKind::Method(..) => "method body", hir::ImplItemKind::Const(..) | hir::ImplItemKind::OpaqueTy(..) - | hir::ImplItemKind::Type(..) => "associated item", + | hir::ImplItemKind::TyAlias(..) => "associated item", } } diff --git a/src/librustc/middle/dead.rs b/src/librustc/middle/dead.rs index fefb3dc076d..55fa261f1ed 100644 --- a/src/librustc/middle/dead.rs +++ b/src/librustc/middle/dead.rs @@ -480,7 +480,7 @@ impl DeadVisitor<'tcx> { hir::ItemKind::Static(..) | hir::ItemKind::Const(..) | hir::ItemKind::Fn(..) - | hir::ItemKind::Ty(..) + | hir::ItemKind::TyAlias(..) | hir::ItemKind::Enum(..) | hir::ItemKind::Struct(..) | hir::ItemKind::Union(..) => true, @@ -640,7 +640,7 @@ impl Visitor<'tcx> for DeadVisitor<'tcx> { self.visit_nested_body(body_id) } hir::ImplItemKind::OpaqueTy(..) | - hir::ImplItemKind::Type(..) => {} + hir::ImplItemKind::TyAlias(..) => {} } } diff --git a/src/librustc/middle/reachable.rs b/src/librustc/middle/reachable.rs index 233cec2ef7d..76d8a6738f0 100644 --- a/src/librustc/middle/reachable.rs +++ b/src/librustc/middle/reachable.rs @@ -189,7 +189,7 @@ impl<'a, 'tcx> ReachableContext<'a, 'tcx> { } } hir::ImplItemKind::OpaqueTy(..) | - hir::ImplItemKind::Type(_) => false, + hir::ImplItemKind::TyAlias(_) => false, } } Some(_) => false, @@ -264,7 +264,7 @@ impl<'a, 'tcx> ReachableContext<'a, 'tcx> { hir::ItemKind::ExternCrate(_) | hir::ItemKind::Use(..) | hir::ItemKind::OpaqueTy(..) | - hir::ItemKind::Ty(..) | + hir::ItemKind::TyAlias(..) | hir::ItemKind::Static(..) | hir::ItemKind::Mod(..) | hir::ItemKind::ForeignMod(..) | @@ -302,7 +302,7 @@ impl<'a, 'tcx> ReachableContext<'a, 'tcx> { } } hir::ImplItemKind::OpaqueTy(..) | - hir::ImplItemKind::Type(_) => {} + hir::ImplItemKind::TyAlias(_) => {} } } Node::Expr(&hir::Expr { node: hir::ExprKind::Closure(.., body, _, _), .. }) => { diff --git a/src/librustc/middle/resolve_lifetime.rs b/src/librustc/middle/resolve_lifetime.rs index 80f85bec879..f8f01f79e1d 100644 --- a/src/librustc/middle/resolve_lifetime.rs +++ b/src/librustc/middle/resolve_lifetime.rs @@ -488,7 +488,7 @@ impl<'a, 'tcx> Visitor<'tcx> for LifetimeContext<'a, 'tcx> { // items. Doing anything on this node is irrelevant, as we currently don't need // it. } - hir::ItemKind::Ty(_, ref generics) + hir::ItemKind::TyAlias(_, ref generics) | hir::ItemKind::OpaqueTy(hir::OpaqueTy { impl_trait_fn: None, ref generics, @@ -828,7 +828,7 @@ impl<'a, 'tcx> Visitor<'tcx> for LifetimeContext<'a, 'tcx> { |this| intravisit::walk_impl_item(this, impl_item), ) } - Type(ref ty) => { + TyAlias(ref ty) => { let generics = &impl_item.generics; let mut index = self.next_early_index(); let mut non_lifetime_count = 0; @@ -1259,7 +1259,7 @@ fn compute_object_lifetime_defaults(tcx: TyCtxt<'_>) -> HirIdMap<Vec<ObjectLifet impl_trait_fn: None, .. }) - | hir::ItemKind::Ty(_, ref generics) + | hir::ItemKind::TyAlias(_, ref generics) | hir::ItemKind::Trait(_, _, ref generics, ..) => { let result = object_lifetime_defaults_for_item(tcx, generics); diff --git a/src/librustc_incremental/persist/dirty_clean.rs b/src/librustc_incremental/persist/dirty_clean.rs index e621101324d..e569a9bc7df 100644 --- a/src/librustc_incremental/persist/dirty_clean.rs +++ b/src/librustc_incremental/persist/dirty_clean.rs @@ -354,7 +354,7 @@ impl DirtyCleanVisitor<'tcx> { HirItem::GlobalAsm(..) => ("ItemGlobalAsm", LABELS_HIR_ONLY), // A type alias, e.g., `type Foo = Bar<u8>` - HirItem::Ty(..) => ("ItemTy", LABELS_HIR_ONLY), + HirItem::TyAlias(..) => ("ItemTy", LABELS_HIR_ONLY), // An enum definition, e.g., `enum Foo<A, B> {C<A>, D<B>}` HirItem::Enum(..) => ("ItemEnum", LABELS_ADT), @@ -405,7 +405,7 @@ impl DirtyCleanVisitor<'tcx> { match item.node { ImplItemKind::Method(..) => ("Node::ImplItem", LABELS_FN_IN_IMPL), ImplItemKind::Const(..) => ("NodeImplConst", LABELS_CONST_IN_IMPL), - ImplItemKind::Type(..) => ("NodeImplType", LABELS_CONST_IN_IMPL), + ImplItemKind::TyAlias(..) => ("NodeImplType", LABELS_CONST_IN_IMPL), ImplItemKind::OpaqueTy(..) => ("NodeImplType", LABELS_CONST_IN_IMPL), } }, diff --git a/src/librustc_lint/builtin.rs b/src/librustc_lint/builtin.rs index 08a8d400779..c9153f285ff 100644 --- a/src/librustc_lint/builtin.rs +++ b/src/librustc_lint/builtin.rs @@ -117,7 +117,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for BoxPointers { fn check_item(&mut self, cx: &LateContext<'_, '_>, it: &hir::Item) { match it.node { hir::ItemKind::Fn(..) | - hir::ItemKind::Ty(..) | + hir::ItemKind::TyAlias(..) | hir::ItemKind::Enum(..) | hir::ItemKind::Struct(..) | hir::ItemKind::Union(..) => { @@ -406,7 +406,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for MissingDoc { } "a trait" } - hir::ItemKind::Ty(..) => "a type alias", + hir::ItemKind::TyAlias(..) => "a type alias", hir::ItemKind::Impl(.., Some(ref trait_ref), _, ref impl_item_refs) => { // If the trait is private, add the impl items to `private_traits` so they don't get // reported for missing docs. @@ -460,7 +460,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for MissingDoc { let desc = match impl_item.node { hir::ImplItemKind::Const(..) => "an associated constant", hir::ImplItemKind::Method(..) => "a method", - hir::ImplItemKind::Type(_) => "an associated type", + hir::ImplItemKind::TyAlias(_) => "an associated type", hir::ImplItemKind::OpaqueTy(_) => "an associated `impl Trait` type", }; self.check_missing_docs_attrs(cx, @@ -1123,7 +1123,7 @@ impl TypeAliasBounds { impl<'a, 'tcx> LateLintPass<'a, 'tcx> for TypeAliasBounds { fn check_item(&mut self, cx: &LateContext<'_, '_>, item: &hir::Item) { let (ty, type_alias_generics) = match item.node { - hir::ItemKind::Ty(ref ty, ref generics) => (&*ty, generics), + hir::ItemKind::TyAlias(ref ty, ref generics) => (&*ty, generics), _ => return, }; let mut suggested_changing_assoc_types = false; diff --git a/src/librustc_lint/nonstandard_style.rs b/src/librustc_lint/nonstandard_style.rs index 84f068ab50a..8f7fe6680cb 100644 --- a/src/librustc_lint/nonstandard_style.rs +++ b/src/librustc_lint/nonstandard_style.rs @@ -137,7 +137,7 @@ impl EarlyLintPass for NonCamelCaseTypes { } match it.node { - ast::ItemKind::Ty(..) | + ast::ItemKind::TyAlias(..) | ast::ItemKind::Enum(..) | ast::ItemKind::Struct(..) | ast::ItemKind::Union(..) => self.check_case(cx, "type", &it.ident), diff --git a/src/librustc_metadata/encoder.rs b/src/librustc_metadata/encoder.rs index 28252117dd2..d73a4966bca 100644 --- a/src/librustc_metadata/encoder.rs +++ b/src/librustc_metadata/encoder.rs @@ -980,7 +980,7 @@ impl EncodeContext<'tcx> { needs_inline || is_const_fn || always_encode_mir }, hir::ImplItemKind::OpaqueTy(..) | - hir::ImplItemKind::Type(..) => false, + hir::ImplItemKind::TyAlias(..) => false, }; Entry { @@ -1094,7 +1094,7 @@ impl EncodeContext<'tcx> { } hir::ItemKind::ForeignMod(_) => EntryKind::ForeignMod, hir::ItemKind::GlobalAsm(..) => EntryKind::GlobalAsm, - hir::ItemKind::Ty(..) => EntryKind::Type, + hir::ItemKind::TyAlias(..) => EntryKind::Type, hir::ItemKind::OpaqueTy(..) => EntryKind::OpaqueTy, hir::ItemKind::Enum(..) => EntryKind::Enum(get_repr_options(tcx, def_id)), hir::ItemKind::Struct(ref struct_def, _) => { @@ -1227,7 +1227,7 @@ impl EncodeContext<'tcx> { hir::ItemKind::Static(..) | hir::ItemKind::Const(..) | hir::ItemKind::Fn(..) | - hir::ItemKind::Ty(..) | + hir::ItemKind::TyAlias(..) | hir::ItemKind::OpaqueTy(..) | hir::ItemKind::Enum(..) | hir::ItemKind::Struct(..) | @@ -1247,7 +1247,7 @@ impl EncodeContext<'tcx> { hir::ItemKind::Static(..) | hir::ItemKind::Const(..) | hir::ItemKind::Fn(..) | - hir::ItemKind::Ty(..) | + hir::ItemKind::TyAlias(..) | hir::ItemKind::Enum(..) | hir::ItemKind::Struct(..) | hir::ItemKind::Union(..) | @@ -1261,7 +1261,7 @@ impl EncodeContext<'tcx> { hir::ItemKind::Static(..) | hir::ItemKind::Const(..) | hir::ItemKind::Fn(..) | - hir::ItemKind::Ty(..) | + hir::ItemKind::TyAlias(..) | hir::ItemKind::Enum(..) | hir::ItemKind::Struct(..) | hir::ItemKind::Union(..) | @@ -1761,7 +1761,7 @@ impl EncodeContext<'tcx> { hir::ItemKind::GlobalAsm(..) | hir::ItemKind::ExternCrate(..) | hir::ItemKind::Use(..) | - hir::ItemKind::Ty(..) | + hir::ItemKind::TyAlias(..) | hir::ItemKind::OpaqueTy(..) | hir::ItemKind::TraitAlias(..) => { // no sub-item recording needed in these cases diff --git a/src/librustc_mir/monomorphize/collector.rs b/src/librustc_mir/monomorphize/collector.rs index b378dadce58..12d763bb791 100644 --- a/src/librustc_mir/monomorphize/collector.rs +++ b/src/librustc_mir/monomorphize/collector.rs @@ -969,7 +969,7 @@ impl ItemLikeVisitor<'v> for RootCollector<'_, 'v> { hir::ItemKind::ExternCrate(..) | hir::ItemKind::Use(..) | hir::ItemKind::ForeignMod(..) | - hir::ItemKind::Ty(..) | + hir::ItemKind::TyAlias(..) | hir::ItemKind::Trait(..) | hir::ItemKind::TraitAlias(..) | hir::ItemKind::OpaqueTy(..) | diff --git a/src/librustc_passes/layout_test.rs b/src/librustc_passes/layout_test.rs index 95cb8de7067..45a185dccf2 100644 --- a/src/librustc_passes/layout_test.rs +++ b/src/librustc_passes/layout_test.rs @@ -31,7 +31,7 @@ impl ItemLikeVisitor<'tcx> for VarianceTest<'tcx> { fn visit_item(&mut self, item: &'tcx hir::Item) { let item_def_id = self.tcx.hir().local_def_id(item.hir_id); - if let ItemKind::Ty(..) = item.node { + if let ItemKind::TyAlias(..) = item.node { for attr in self.tcx.get_attrs(item_def_id).iter() { if attr.check_name(sym::rustc_layout) { self.dump_layout_of(item_def_id, item, attr); diff --git a/src/librustc_privacy/lib.rs b/src/librustc_privacy/lib.rs index ac18f0e440b..4800bb9365c 100644 --- a/src/librustc_privacy/lib.rs +++ b/src/librustc_privacy/lib.rs @@ -534,7 +534,7 @@ impl Visitor<'tcx> for EmbargoVisitor<'tcx> { hir::ItemKind::Static(..) | hir::ItemKind::Struct(..) | hir::ItemKind::Trait(..) | hir::ItemKind::TraitAlias(..) | hir::ItemKind::OpaqueTy(..) | - hir::ItemKind::Ty(..) | hir::ItemKind::Union(..) | hir::ItemKind::Use(..) => { + hir::ItemKind::TyAlias(..) | hir::ItemKind::Union(..) | hir::ItemKind::Use(..) => { if item.vis.node.is_pub() { self.prev_level } else { None } } }; @@ -589,7 +589,7 @@ impl Visitor<'tcx> for EmbargoVisitor<'tcx> { hir::ItemKind::Static(..) | hir::ItemKind::Const(..) | hir::ItemKind::GlobalAsm(..) | - hir::ItemKind::Ty(..) | + hir::ItemKind::TyAlias(..) | hir::ItemKind::Mod(..) | hir::ItemKind::TraitAlias(..) | hir::ItemKind::Fn(..) | @@ -621,7 +621,7 @@ impl Visitor<'tcx> for EmbargoVisitor<'tcx> { } // Visit everything. hir::ItemKind::Const(..) | hir::ItemKind::Static(..) | - hir::ItemKind::Fn(..) | hir::ItemKind::Ty(..) => { + hir::ItemKind::Fn(..) | hir::ItemKind::TyAlias(..) => { if item_level.is_some() { self.reach(item.hir_id, item_level).generics().predicates().ty(); } @@ -1371,7 +1371,7 @@ impl<'a, 'tcx> Visitor<'tcx> for ObsoleteVisiblePrivateTypesVisitor<'a, 'tcx> { impl_item_ref.id.hir_id) } hir::ImplItemKind::OpaqueTy(..) | - hir::ImplItemKind::Type(_) => false, + hir::ImplItemKind::TyAlias(_) => false, } }); @@ -1397,7 +1397,7 @@ impl<'a, 'tcx> Visitor<'tcx> for ObsoleteVisiblePrivateTypesVisitor<'a, 'tcx> { { intravisit::walk_impl_item(self, impl_item) } - hir::ImplItemKind::Type(..) => { + hir::ImplItemKind::TyAlias(..) => { intravisit::walk_impl_item(self, impl_item) } _ => {} @@ -1423,7 +1423,7 @@ impl<'a, 'tcx> Visitor<'tcx> for ObsoleteVisiblePrivateTypesVisitor<'a, 'tcx> { // Those in 3. are warned with this call. for impl_item_ref in impl_item_refs { let impl_item = self.tcx.hir().impl_item(impl_item_ref.id); - if let hir::ImplItemKind::Type(ref ty) = impl_item.node { + if let hir::ImplItemKind::TyAlias(ref ty) = impl_item.node { self.visit_ty(ty); } } @@ -1458,7 +1458,7 @@ impl<'a, 'tcx> Visitor<'tcx> for ObsoleteVisiblePrivateTypesVisitor<'a, 'tcx> { // `type ... = ...;` can contain private types, because // we're introducing a new name. - hir::ItemKind::Ty(..) => return, + hir::ItemKind::TyAlias(..) => return, // Not at all public, so we don't care. _ if !self.item_is_public(&item.hir_id, &item.vis) => { @@ -1739,7 +1739,7 @@ impl<'a, 'tcx> Visitor<'tcx> for PrivateItemsInPublicInterfacesVisitor<'a, 'tcx> hir::ItemKind::GlobalAsm(..) => {} // Subitems of these items have inherited publicity. hir::ItemKind::Const(..) | hir::ItemKind::Static(..) | - hir::ItemKind::Fn(..) | hir::ItemKind::Ty(..) => { + hir::ItemKind::Fn(..) | hir::ItemKind::TyAlias(..) => { self.check(item.hir_id, item_visibility).generics().predicates().ty(); } hir::ItemKind::OpaqueTy(..) => { diff --git a/src/librustc_resolve/build_reduced_graph.rs b/src/librustc_resolve/build_reduced_graph.rs index b66cc9e57f7..9d01f330029 100644 --- a/src/librustc_resolve/build_reduced_graph.rs +++ b/src/librustc_resolve/build_reduced_graph.rs @@ -459,7 +459,7 @@ impl<'a> Resolver<'a> { } // These items live in the type namespace. - ItemKind::Ty(..) => { + ItemKind::TyAlias(..) => { let res = Res::Def(DefKind::TyAlias, self.definitions.local_def_id(item.id)); self.define(parent, ident, TypeNS, (res, vis, sp, expansion)); } diff --git a/src/librustc_resolve/lib.rs b/src/librustc_resolve/lib.rs index a49be7c27c9..a7062840a6f 100644 --- a/src/librustc_resolve/lib.rs +++ b/src/librustc_resolve/lib.rs @@ -2709,7 +2709,7 @@ impl<'a> Resolver<'a> { debug!("(resolving item) resolving {} ({:?})", name, item.node); match item.node { - ItemKind::Ty(_, ref generics) | + ItemKind::TyAlias(_, ref generics) | ItemKind::OpaqueTy(_, ref generics) | ItemKind::Fn(_, _, ref generics, _) => { self.with_generic_param_rib( @@ -3079,7 +3079,7 @@ impl<'a> Resolver<'a> { visit::walk_impl_item(this, impl_item); } - ImplItemKind::Type(ref ty) => { + ImplItemKind::TyAlias(ref ty) => { // If this is a trait impl, ensure the type // exists in trait this.check_trait_item(impl_item.ident, diff --git a/src/librustc_save_analysis/dump_visitor.rs b/src/librustc_save_analysis/dump_visitor.rs index 3abec9307ee..c32d4885c4a 100644 --- a/src/librustc_save_analysis/dump_visitor.rs +++ b/src/librustc_save_analysis/dump_visitor.rs @@ -1167,7 +1167,7 @@ impl<'l, 'tcx> DumpVisitor<'l, 'tcx> { impl_item.span, ); } - ast::ImplItemKind::Type(ref ty) => { + ast::ImplItemKind::TyAlias(ref ty) => { // FIXME: uses of the assoc type should ideally point to this // 'def' and the name here should be a ref to the def in the // trait. @@ -1397,7 +1397,7 @@ impl<'l, 'tcx> Visitor<'l> for DumpVisitor<'l, 'tcx> { self.process_mod(item); visit::walk_mod(self, m); } - Ty(ref ty, ref ty_params) => { + TyAlias(ref ty, ref ty_params) => { let qualname = format!("::{}", self.tcx.def_path_str(self.tcx.hir().local_def_id_from_node_id(item.id))); let value = ty_to_string(&ty); diff --git a/src/librustc_save_analysis/sig.rs b/src/librustc_save_analysis/sig.rs index cbfaf91cdfc..c212cda2d66 100644 --- a/src/librustc_save_analysis/sig.rs +++ b/src/librustc_save_analysis/sig.rs @@ -438,7 +438,7 @@ impl Sig for ast::Item { refs: vec![], }) } - ast::ItemKind::Ty(ref ty, ref generics) => { + ast::ItemKind::TyAlias(ref ty, ref generics) => { let text = "type ".to_owned(); let mut sig = name_and_generics(text, offset, generics, self.id, self.ident, scx)?; diff --git a/src/librustc_typeck/check/mod.rs b/src/librustc_typeck/check/mod.rs index 8d6f9185962..e8ff83e7d2b 100644 --- a/src/librustc_typeck/check/mod.rs +++ b/src/librustc_typeck/check/mod.rs @@ -1409,7 +1409,7 @@ pub fn check_item_type<'tcx>(tcx: TyCtxt<'tcx>, it: &'tcx hir::Item) { let substs = InternalSubsts::identity_for_item(tcx, def_id); check_opaque(tcx, def_id, substs, it.span, &origin); } - hir::ItemKind::Ty(..) => { + hir::ItemKind::TyAlias(..) => { let def_id = tcx.hir().local_def_id(it.hir_id); let pty_ty = tcx.type_of(def_id); let generics = tcx.generics_of(def_id); @@ -1543,7 +1543,7 @@ fn check_specialization_validity<'tcx>( hir::ImplItemKind::Const(..) => ty::AssocKind::Const, hir::ImplItemKind::Method(..) => ty::AssocKind::Method, hir::ImplItemKind::OpaqueTy(..) => ty::AssocKind::OpaqueTy, - hir::ImplItemKind::Type(_) => ty::AssocKind::Type + hir::ImplItemKind::TyAlias(_) => ty::AssocKind::Type, }; let parent = ancestors.defs(tcx, trait_item.ident, kind, trait_def.def_id).nth(1) @@ -1640,7 +1640,7 @@ fn check_impl_items_against_trait<'tcx>( } } hir::ImplItemKind::OpaqueTy(..) | - hir::ImplItemKind::Type(_) => { + hir::ImplItemKind::TyAlias(_) => { if ty_trait_item.kind == ty::AssocKind::Type { if ty_trait_item.defaultness.has_value() { overridden_associated_type = Some(impl_item); diff --git a/src/librustc_typeck/collect.rs b/src/librustc_typeck/collect.rs index 15687eaa943..a14040fe59a 100644 --- a/src/librustc_typeck/collect.rs +++ b/src/librustc_typeck/collect.rs @@ -293,7 +293,7 @@ fn type_param_predicates( match item.node { ItemKind::Fn(.., ref generics, _) | ItemKind::Impl(_, _, _, ref generics, ..) - | ItemKind::Ty(_, ref generics) + | ItemKind::TyAlias(_, ref generics) | ItemKind::OpaqueTy(OpaqueTy { ref generics, impl_trait_fn: None, @@ -462,7 +462,7 @@ fn convert_item(tcx: TyCtxt<'_>, item_id: hir::HirId) { }) => {} hir::ItemKind::OpaqueTy(..) - | hir::ItemKind::Ty(..) + | hir::ItemKind::TyAlias(..) | hir::ItemKind::Static(..) | hir::ItemKind::Const(..) | hir::ItemKind::Fn(..) => { @@ -917,7 +917,7 @@ fn generics_of(tcx: TyCtxt<'_>, def_id: DefId) -> &ty::Generics { generics } - ItemKind::Ty(_, ref generics) + ItemKind::TyAlias(_, ref generics) | ItemKind::Enum(_, ref generics) | ItemKind::Struct(_, ref generics) | ItemKind::OpaqueTy(hir::OpaqueTy { ref generics, .. }) @@ -1220,7 +1220,7 @@ pub fn checked_type_of(tcx: TyCtxt<'_>, def_id: DefId, fail: bool) -> Option<Ty< find_opaque_ty_constraints(tcx, def_id) } - ImplItemKind::Type(ref ty) => { + ImplItemKind::TyAlias(ref ty) => { if tcx .impl_trait_ref(tcx.hir().get_parent_did(hir_id)) .is_none() @@ -1242,7 +1242,7 @@ pub fn checked_type_of(tcx: TyCtxt<'_>, def_id: DefId, fail: bool) -> Option<Ty< icx.to_ty(ty) } }, - ItemKind::Ty(ref ty, _) + ItemKind::TyAlias(ref ty, _) | ItemKind::Impl(.., ref ty, _) => icx.to_ty(ty), ItemKind::Fn(..) => { let substs = InternalSubsts::identity_for_item(tcx, def_id); @@ -2038,7 +2038,7 @@ fn explicit_predicates_of( generics } ItemKind::Fn(.., ref generics, _) - | ItemKind::Ty(_, ref generics) + | ItemKind::TyAlias(_, ref generics) | ItemKind::Enum(_, ref generics) | ItemKind::Struct(_, ref generics) | ItemKind::Union(_, ref generics) => generics, diff --git a/src/librustc_typeck/impl_wf_check.rs b/src/librustc_typeck/impl_wf_check.rs index 029a8f9c41f..fcfd9adef54 100644 --- a/src/librustc_typeck/impl_wf_check.rs +++ b/src/librustc_typeck/impl_wf_check.rs @@ -189,7 +189,7 @@ fn enforce_impl_items_are_distinct(tcx: TyCtxt<'_>, impl_item_refs: &[hir::ImplI for impl_item_ref in impl_item_refs { let impl_item = tcx.hir().impl_item(impl_item_ref.id); let seen_items = match impl_item.node { - hir::ImplItemKind::Type(_) => &mut seen_type_items, + hir::ImplItemKind::TyAlias(_) => &mut seen_type_items, _ => &mut seen_value_items, }; match seen_items.entry(impl_item.ident.modern()) { diff --git a/src/librustc_typeck/namespace.rs b/src/librustc_typeck/namespace.rs index 732f0d3ebf2..1e1d3e7865c 100644 --- a/src/librustc_typeck/namespace.rs +++ b/src/librustc_typeck/namespace.rs @@ -23,7 +23,7 @@ impl<'a> From <&'a hir::ImplItemKind> for Namespace { fn from(impl_kind: &'a hir::ImplItemKind) -> Self { match *impl_kind { hir::ImplItemKind::OpaqueTy(..) | - hir::ImplItemKind::Type(..) => Namespace::Type, + hir::ImplItemKind::TyAlias(..) => Namespace::Type, hir::ImplItemKind::Const(..) | hir::ImplItemKind::Method(..) => Namespace::Value, } diff --git a/src/librustdoc/clean/mod.rs b/src/librustdoc/clean/mod.rs index a7fb18c3f2c..d3accff5c2c 100644 --- a/src/librustdoc/clean/mod.rs +++ b/src/librustdoc/clean/mod.rs @@ -2253,7 +2253,7 @@ impl Clean<Item> for hir::ImplItem { hir::ImplItemKind::Method(ref sig, body) => { MethodItem((sig, &self.generics, body, Some(self.defaultness)).clean(cx)) } - hir::ImplItemKind::Type(ref ty) => TypedefItem(Typedef { + hir::ImplItemKind::TyAlias(ref ty) => TypedefItem(Typedef { type_: ty.clean(cx), generics: Generics::default(), }, true), @@ -2802,7 +2802,7 @@ impl Clean<Type> for hir::Ty { } }; - if let Some(&hir::ItemKind::Ty(ref ty, ref generics)) = alias { + if let Some(&hir::ItemKind::TyAlias(ref ty, ref generics)) = alias { let provided_params = &path.segments.last().expect("segments were empty"); let mut ty_substs = FxHashMap::default(); let mut lt_substs = FxHashMap::default(); diff --git a/src/librustdoc/visit_ast.rs b/src/librustdoc/visit_ast.rs index 098cecef95c..1ba2c0333d6 100644 --- a/src/librustdoc/visit_ast.rs +++ b/src/librustdoc/visit_ast.rs @@ -458,7 +458,7 @@ impl<'a, 'tcx> RustdocVisitor<'a, 'tcx> { om.unions.push(self.visit_union_data(item, ident.name, sd, gen)), hir::ItemKind::Fn(ref fd, header, ref gen, body) => self.visit_fn(om, item, ident.name, &**fd, header, gen, body), - hir::ItemKind::Ty(ref ty, ref gen) => { + hir::ItemKind::TyAlias(ref ty, ref gen) => { let t = Typedef { ty, gen, diff --git a/src/libsyntax/ast.rs b/src/libsyntax/ast.rs index ea8fa023855..849e77c4f31 100644 --- a/src/libsyntax/ast.rs +++ b/src/libsyntax/ast.rs @@ -1509,7 +1509,7 @@ pub struct ImplItem { pub enum ImplItemKind { Const(P<Ty>, P<Expr>), Method(MethodSig, P<Block>), - Type(P<Ty>), + TyAlias(P<Ty>), OpaqueTy(GenericBounds), Macro(Mac), } @@ -2346,7 +2346,7 @@ pub enum ItemKind { /// A type alias (`type` or `pub type`). /// /// E.g., `type Foo = Bar<u8>;`. - Ty(P<Ty>, Generics), + TyAlias(P<Ty>, Generics), /// An opaque `impl Trait` type alias. /// /// E.g., `type Foo = impl Bar + Boo;`. @@ -2403,7 +2403,7 @@ impl ItemKind { ItemKind::Mod(..) => "module", ItemKind::ForeignMod(..) => "foreign module", ItemKind::GlobalAsm(..) => "global asm", - ItemKind::Ty(..) => "type alias", + ItemKind::TyAlias(..) => "type alias", ItemKind::OpaqueTy(..) => "opaque type", ItemKind::Enum(..) => "enum", ItemKind::Struct(..) => "struct", diff --git a/src/libsyntax/ext/build.rs b/src/libsyntax/ext/build.rs index b4b15ba31b7..59e13fdc8f1 100644 --- a/src/libsyntax/ext/build.rs +++ b/src/libsyntax/ext/build.rs @@ -858,7 +858,7 @@ impl<'a> ExtCtxt<'a> { pub fn item_ty_poly(&self, span: Span, name: Ident, ty: P<ast::Ty>, generics: Generics) -> P<ast::Item> { - self.item(span, name, Vec::new(), ast::ItemKind::Ty(ty, generics)) + self.item(span, name, Vec::new(), ast::ItemKind::TyAlias(ty, generics)) } pub fn item_ty(&self, span: Span, name: Ident, ty: P<ast::Ty>) -> P<ast::Item> { diff --git a/src/libsyntax/feature_gate.rs b/src/libsyntax/feature_gate.rs index 33d10b269e1..76ea8e607b7 100644 --- a/src/libsyntax/feature_gate.rs +++ b/src/libsyntax/feature_gate.rs @@ -2254,7 +2254,7 @@ impl<'a> Visitor<'a> for PostExpansionVisitor<'a> { "`impl Trait` in type aliases is unstable" ); } - ast::ImplItemKind::Type(_) => { + ast::ImplItemKind::TyAlias(_) => { if !ii.generics.params.is_empty() { gate_feature_post!(&self, generic_associated_types, ii.span, "generic associated types are unstable"); diff --git a/src/libsyntax/mut_visit.rs b/src/libsyntax/mut_visit.rs index cbad74e1561..be04c6a76b0 100644 --- a/src/libsyntax/mut_visit.rs +++ b/src/libsyntax/mut_visit.rs @@ -847,7 +847,7 @@ pub fn noop_visit_item_kind<T: MutVisitor>(kind: &mut ItemKind, vis: &mut T) { ItemKind::Mod(m) => vis.visit_mod(m), ItemKind::ForeignMod(nm) => vis.visit_foreign_mod(nm), ItemKind::GlobalAsm(_ga) => {} - ItemKind::Ty(ty, generics) => { + ItemKind::TyAlias(ty, generics) => { vis.visit_ty(ty); vis.visit_generics(generics); } @@ -933,7 +933,7 @@ pub fn noop_flat_map_impl_item<T: MutVisitor>(mut item: ImplItem, visitor: &mut visit_method_sig(sig, visitor); visitor.visit_block(body); } - ImplItemKind::Type(ty) => visitor.visit_ty(ty), + ImplItemKind::TyAlias(ty) => visitor.visit_ty(ty), ImplItemKind::OpaqueTy(bounds) => visit_bounds(bounds, visitor), ImplItemKind::Macro(mac) => visitor.visit_mac(mac), } diff --git a/src/libsyntax/parse/parser.rs b/src/libsyntax/parse/parser.rs index b14000aeaf3..d85c2df16a3 100644 --- a/src/libsyntax/parse/parser.rs +++ b/src/libsyntax/parse/parser.rs @@ -5707,7 +5707,7 @@ impl<'a> Parser<'a> { let (name, node, generics) = if let Some(type_) = self.eat_type() { let (name, alias, generics) = type_?; let kind = match alias { - AliasKind::Weak(typ) => ast::ImplItemKind::Type(typ), + AliasKind::Weak(typ) => ast::ImplItemKind::TyAlias(typ), AliasKind::OpaqueTy(bounds) => ast::ImplItemKind::OpaqueTy(bounds), }; (name, kind, generics) @@ -7263,7 +7263,7 @@ impl<'a> Parser<'a> { let (ident, alias, generics) = type_?; // TYPE ITEM let item_ = match alias { - AliasKind::Weak(ty) => ItemKind::Ty(ty, generics), + AliasKind::Weak(ty) => ItemKind::TyAlias(ty, generics), AliasKind::OpaqueTy(bounds) => ItemKind::OpaqueTy(bounds, generics), }; let prev_span = self.prev_span; diff --git a/src/libsyntax/print/pprust.rs b/src/libsyntax/print/pprust.rs index f3989be45dd..2ef8a919b9c 100644 --- a/src/libsyntax/print/pprust.rs +++ b/src/libsyntax/print/pprust.rs @@ -1208,7 +1208,7 @@ impl<'a> State<'a> { self.s.word(ga.asm.as_str().to_string()); self.end(); } - ast::ItemKind::Ty(ref ty, ref generics) => { + ast::ItemKind::TyAlias(ref ty, ref generics) => { self.head(visibility_qualified(&item.vis, "type")); self.print_ident(item.ident); self.print_generic_params(&generics.params); @@ -1579,7 +1579,7 @@ impl<'a> State<'a> { self.nbsp(); self.print_block_with_attrs(body, &ii.attrs); } - ast::ImplItemKind::Type(ref ty) => { + ast::ImplItemKind::TyAlias(ref ty) => { self.print_associated_type(ii.ident, None, Some(ty)); } ast::ImplItemKind::OpaqueTy(ref bounds) => { diff --git a/src/libsyntax/visit.rs b/src/libsyntax/visit.rs index 67226c2177f..596c5b46b98 100644 --- a/src/libsyntax/visit.rs +++ b/src/libsyntax/visit.rs @@ -255,7 +255,7 @@ pub fn walk_item<'a, V: Visitor<'a>>(visitor: &mut V, item: &'a Item) { walk_list!(visitor, visit_foreign_item, &foreign_module.items); } ItemKind::GlobalAsm(ref ga) => visitor.visit_global_asm(ga), - ItemKind::Ty(ref typ, ref generics) => { + ItemKind::TyAlias(ref typ, ref generics) => { visitor.visit_ty(typ); visitor.visit_generics(generics) } @@ -616,7 +616,7 @@ pub fn walk_impl_item<'a, V: Visitor<'a>>(visitor: &mut V, impl_item: &'a ImplIt visitor.visit_fn(FnKind::Method(impl_item.ident, sig, Some(&impl_item.vis), body), &sig.decl, impl_item.span, impl_item.id); } - ImplItemKind::Type(ref ty) => { + ImplItemKind::TyAlias(ref ty) => { visitor.visit_ty(ty); } ImplItemKind::OpaqueTy(ref bounds) => { diff --git a/src/libsyntax_ext/deriving/generic/mod.rs b/src/libsyntax_ext/deriving/generic/mod.rs index 4a0c4a39f78..cb89a68b9f2 100644 --- a/src/libsyntax_ext/deriving/generic/mod.rs +++ b/src/libsyntax_ext/deriving/generic/mod.rs @@ -529,7 +529,8 @@ impl<'a> TraitDef<'a> { defaultness: ast::Defaultness::Final, attrs: Vec::new(), generics: Generics::default(), - node: ast::ImplItemKind::Type(type_def.to_ty(cx, self.span, type_ident, generics)), + node: ast::ImplItemKind::TyAlias( + type_def.to_ty(cx, self.span, type_ident, generics)), tokens: None, } }); |
