about summary refs log tree commit diff
path: root/src
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2023-12-03 16:28:22 +0000
committerbors <bors@rust-lang.org>2023-12-03 16:28:22 +0000
commitdb07cccb1e6b448eb1fec576096b587680e4ff69 (patch)
tree9e8ce5f2d1a586120a74c56d5e211c987bac4502 /src
parent21d88b32cb5ff05b7a43c99e7c508bbbc65e036d (diff)
parent45e634234690a7d061e133b8cf9d31af34b29a0b (diff)
downloadrust-db07cccb1e6b448eb1fec576096b587680e4ff69.tar.gz
rust-db07cccb1e6b448eb1fec576096b587680e4ff69.zip
Auto merge of #113730 - belovdv:jobserver-init-check, r=petrochenkov
Report errors in jobserver inherited through environment variables

This pr attempts to catch situations, when jobserver exists, but is not being inherited.

r? `@petrochenkov`
Diffstat (limited to 'src')
-rw-r--r--src/tools/miri/cargo-miri/src/phases.rs8
1 files changed, 8 insertions, 0 deletions
diff --git a/src/tools/miri/cargo-miri/src/phases.rs b/src/tools/miri/cargo-miri/src/phases.rs
index d655df6d994..a7412f90c85 100644
--- a/src/tools/miri/cargo-miri/src/phases.rs
+++ b/src/tools/miri/cargo-miri/src/phases.rs
@@ -501,6 +501,14 @@ pub fn phase_runner(mut binary_args: impl Iterator<Item = String>, phase: Runner
     // Set missing env vars. We prefer build-time env vars over run-time ones; see
     // <https://github.com/rust-lang/miri/issues/1661> for the kind of issue that fixes.
     for (name, val) in info.env {
+        // `CARGO_MAKEFLAGS` contains information about how to reach the
+        // jobserver, but by the time the program is being run, that jobserver
+        // no longer exists. Hence we shouldn't forward this.
+        // FIXME: Miri builds the final crate without a jobserver.
+        // This may be fixed with github.com/rust-lang/cargo/issues/12597.
+        if name == "CARGO_MAKEFLAGS" {
+            continue;
+        }
         if let Some(old_val) = env::var_os(&name) {
             if old_val == val {
                 // This one did not actually change, no need to re-set it.