about summary refs log tree commit diff
path: root/src
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2015-07-13 12:24:25 +0000
committerbors <bors@rust-lang.org>2015-07-13 12:24:25 +0000
commitdf39a92e22d90d21d6b8ce46d8d64bd127335cbd (patch)
treefb6eb4d3be62ee1d1a449434ae1c95f1f3871cb4 /src
parentedf29a710218a0c7037f064e8823b304541be124 (diff)
parent043d7b519871792860968680121bd98c02575c8f (diff)
downloadrust-df39a92e22d90d21d6b8ce46d8d64bd127335cbd.tar.gz
rust-df39a92e22d90d21d6b8ce46d8d64bd127335cbd.zip
Auto merge of #27011 - dotdash:issue-26996, r=luqmana
If we match a whole struct or tuple, the "field" for the reassignment
checker will be "None" which means that mutating any field should count
as a reassignment.

Fixes #26996.
Diffstat (limited to 'src')
-rw-r--r--src/librustc_trans/trans/_match.rs3
-rw-r--r--src/test/run-pass/issue-26996.rs19
2 files changed, 21 insertions, 1 deletions
diff --git a/src/librustc_trans/trans/_match.rs b/src/librustc_trans/trans/_match.rs
index 3aa98ab031d..9a9b9c617a8 100644
--- a/src/librustc_trans/trans/_match.rs
+++ b/src/librustc_trans/trans/_match.rs
@@ -1384,7 +1384,8 @@ impl<'tcx> euv::Delegate<'tcx> for ReassignmentChecker {
                 match base_cmt.cat {
                     mc::cat_upvar(mc::Upvar { id: ty::UpvarId { var_id: vid, .. }, .. }) |
                     mc::cat_local(vid) => {
-                        self.reassigned |= self.node == vid && Some(field) == self.field
+                        self.reassigned |= self.node == vid &&
+                            (self.field.is_none() || Some(field) == self.field)
                     },
                     _ => {}
                 }
diff --git a/src/test/run-pass/issue-26996.rs b/src/test/run-pass/issue-26996.rs
new file mode 100644
index 00000000000..e17845a68bc
--- /dev/null
+++ b/src/test/run-pass/issue-26996.rs
@@ -0,0 +1,19 @@
+// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
+// file at the top-level directory of this distribution and at
+// http://rust-lang.org/COPYRIGHT.
+//
+// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
+// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
+// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
+// option. This file may not be copied, modified, or distributed
+// except according to those terms.
+
+fn main() {
+    let mut c = (1, "".to_owned());
+    match c {
+        c2 => {
+            c.0 = 2;
+            assert_eq!(c2.0, 1);
+        }
+    }
+}