diff options
| author | bors <bors@rust-lang.org> | 2020-10-12 20:59:43 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2020-10-12 20:59:43 +0000 |
| commit | febd0086a5ea6475d8243c7651908ddd96711896 (patch) | |
| tree | 1ba0052a5b0f550cf96ecdf0fffabbb65aff3582 /src | |
| parent | 18ffea01eeea09cd273de0ff37e0ac8b5b70f7c5 (diff) | |
| parent | 7b3493c0e95e8cf9656d2cefffc621cb3e5eb726 (diff) | |
| download | rust-febd0086a5ea6475d8243c7651908ddd96711896.tar.gz rust-febd0086a5ea6475d8243c7651908ddd96711896.zip | |
Auto merge of #6163 - phansch:remove-one-lazy-static, r=flip1995
Remove lazy_static completely and use once_cell feature instead Follow-up to https://github.com/rust-lang/rust-clippy/pull/6120 This removes the last remaining `lazy_static` usages and replaces them with `SyncLazy` from the `once_cell` feature. --- changelog: none
Diffstat (limited to 'src')
| -rw-r--r-- | src/driver.rs | 17 | ||||
| -rw-r--r-- | src/lintlist/mod.rs | 13 |
2 files changed, 15 insertions, 15 deletions
diff --git a/src/driver.rs b/src/driver.rs index 377f6d22446..e5d740cecd3 100644 --- a/src/driver.rs +++ b/src/driver.rs @@ -1,4 +1,5 @@ #![feature(rustc_private)] +#![feature(once_cell)] #![cfg_attr(feature = "deny-warnings", deny(warnings))] // warn on lints, that are included in `rust-lang/rust`s bootstrap #![warn(rust_2018_idioms, unused_lifetimes)] @@ -17,9 +18,9 @@ use rustc_interface::interface; use rustc_middle::ty::TyCtxt; use rustc_tools_util::VersionInfo; -use lazy_static::lazy_static; use std::borrow::Cow; use std::env; +use std::lazy::SyncLazy; use std::ops::Deref; use std::panic; use std::path::{Path, PathBuf}; @@ -230,13 +231,11 @@ You can use tool lints to allow or deny lints from your code, eg.: const BUG_REPORT_URL: &str = "https://github.com/rust-lang/rust-clippy/issues/new"; -lazy_static! { - static ref ICE_HOOK: Box<dyn Fn(&panic::PanicInfo<'_>) + Sync + Send + 'static> = { - let hook = panic::take_hook(); - panic::set_hook(Box::new(|info| report_clippy_ice(info, BUG_REPORT_URL))); - hook - }; -} +static ICE_HOOK: SyncLazy<Box<dyn Fn(&panic::PanicInfo<'_>) + Sync + Send + 'static>> = SyncLazy::new(|| { + let hook = panic::take_hook(); + panic::set_hook(Box::new(|info| report_clippy_ice(info, BUG_REPORT_URL))); + hook +}); fn report_clippy_ice(info: &panic::PanicInfo<'_>, bug_report_url: &str) { // Invoke our ICE handler, which prints the actual panic message and optionally a backtrace @@ -295,7 +294,7 @@ fn toolchain_path(home: Option<String>, toolchain: Option<String>) -> Option<Pat pub fn main() { rustc_driver::init_rustc_env_logger(); - lazy_static::initialize(&ICE_HOOK); + SyncLazy::force(&ICE_HOOK); exit(rustc_driver::catch_with_exit_code(move || { let mut orig_args: Vec<String> = env::args().collect(); diff --git a/src/lintlist/mod.rs b/src/lintlist/mod.rs index d0fc8f0c8a9..624223ff706 100644 --- a/src/lintlist/mod.rs +++ b/src/lintlist/mod.rs @@ -1,15 +1,16 @@ -//! This file is managed by `cargo dev update_lints`. Do not edit. +//! This file is managed by `cargo dev update_lints`. Do not edit or format this file. -use lazy_static::lazy_static; +use std::lazy::SyncLazy; pub mod lint; pub use lint::Level; pub use lint::Lint; pub use lint::LINT_LEVELS; -lazy_static! { +#[rustfmt::skip] +pub static ALL_LINTS: SyncLazy<Vec<Lint>> = SyncLazy::new(|| { // begin lint list, do not remove this comment, it’s used in `update_lints` -pub static ref ALL_LINTS: Vec<Lint> = vec![ +vec![ Lint { name: "absurd_extreme_comparisons", group: "correctness", @@ -2831,6 +2832,6 @@ pub static ref ALL_LINTS: Vec<Lint> = vec![ deprecation: None, module: "methods", }, -]; +] // end lint list, do not remove this comment, it’s used in `update_lints` -} +}); |
