about summary refs log tree commit diff
path: root/tests/codegen/global_asm_include.rs
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2023-07-31 06:28:01 +0000
committerbors <bors@rust-lang.org>2023-07-31 06:28:01 +0000
commit03b8b50fcb0c95e1f5ce303572ed4516a59a9b15 (patch)
tree8364130465756a65f2a9d49f071b1e7868df952e /tests/codegen/global_asm_include.rs
parent3be07c116128527fd9b9392f819b0dc502ff9fe5 (diff)
parent20ebbf467d5bc6eca39ca014c4258aa6835b18db (diff)
downloadrust-03b8b50fcb0c95e1f5ce303572ed4516a59a9b15.tar.gz
rust-03b8b50fcb0c95e1f5ce303572ed4516a59a9b15.zip
Auto merge of #114225 - workingjubilee:only-golden-arches, r=compiler-errors
Only golden arches

A number of tests in the test suite have applied the somewhat comedic practice of ignoring *every* single target architecture that rustc has ever supported. This is silly, when they are clearly tests built around certain assumptions, primarily of the x86-64 architecture, or in one case when they are only relevant for a handful of 32-bit targets. This has even resulted, in one case, in the same architecture being ignored twice!

Document these better, and use a "revision + only-arch" idiom in the test headers to denote the "golden arches" that actually pass these tests.
Diffstat (limited to 'tests/codegen/global_asm_include.rs')
-rw-r--r--tests/codegen/global_asm_include.rs24
1 files changed, 3 insertions, 21 deletions
diff --git a/tests/codegen/global_asm_include.rs b/tests/codegen/global_asm_include.rs
index e25c164f407..0fede8c71e4 100644
--- a/tests/codegen/global_asm_include.rs
+++ b/tests/codegen/global_asm_include.rs
@@ -1,24 +1,6 @@
-// ignore-aarch64
-// ignore-arm
-// ignore-avr
-// ignore-bpf
-// ignore-bpf
-// ignore-hexagon
-// ignore-mips
-// ignore-mips64
-// ignore-msp430
-// ignore-powerpc64
-// ignore-powerpc
-// ignore-sparc
-// ignore-sparc64
-// ignore-s390x
-// ignore-thumb
-// ignore-nvptx64
-// ignore-spirv
-// ignore-wasm32
-// ignore-wasm64
-// ignore-emscripten
-// ignore-loongarch64
+// revisions: x32 x64
+//[x32] only-x86
+//[x64] only-x86_64
 // compile-flags: -C no-prepopulate-passes
 
 #![crate_type = "lib"]