about summary refs log tree commit diff
path: root/tests/codegen/issues
diff options
context:
space:
mode:
authorJörn Horstmann <git@jhorstmann.net>2024-04-10 22:22:18 +0200
committerJörn Horstmann <git@jhorstmann.net>2024-09-23 11:31:29 +0200
commite393f56d37857d3b690b687fe54e8413bb9d5b3a (patch)
tree0b73ce9cb81517c1ffec620db2c1d10f6b6bbbe0 /tests/codegen/issues
parent702987f75b74f789ba227ee04a3d7bb1680c2309 (diff)
downloadrust-e393f56d37857d3b690b687fe54e8413bb9d5b3a.tar.gz
rust-e393f56d37857d3b690b687fe54e8413bb9d5b3a.zip
Improve autovectorization of to_lowercase / to_uppercase functions
Refactor the code in the `convert_while_ascii` helper function to make
it more suitable for auto-vectorization and also process the full ascii
prefix of the string. The generic case conversion logic will only be
invoked starting from the first non-ascii character.

The runtime on microbenchmarks with ascii-only inputs improves between
1.5x for short and 4x for long inputs on x86_64 and aarch64.

The new implementation also encapsulates all unsafe inside the
`convert_while_ascii` function.

Fixes #123712
Diffstat (limited to 'tests/codegen/issues')
-rw-r--r--tests/codegen/issues/issue-123712-str-to-lower-autovectorization.rs23
1 files changed, 23 insertions, 0 deletions
diff --git a/tests/codegen/issues/issue-123712-str-to-lower-autovectorization.rs b/tests/codegen/issues/issue-123712-str-to-lower-autovectorization.rs
new file mode 100644
index 00000000000..11ee10e8cc3
--- /dev/null
+++ b/tests/codegen/issues/issue-123712-str-to-lower-autovectorization.rs
@@ -0,0 +1,23 @@
+//@ only-x86_64
+//@ compile-flags: -C opt-level=3
+#![crate_type = "lib"]
+#![no_std]
+#![feature(str_internals)]
+
+extern crate alloc;
+
+/// Ensure that the ascii-prefix loop for `str::to_lowercase` and `str::to_uppercase` uses vector
+/// instructions.
+///
+/// The llvm ir should be the same for all targets that support some form of simd. Only targets
+/// without any simd instructions would see scalarized ir.
+/// Unfortunately, there is no `only-simd` directive to only run this test on only such platforms,
+/// and using test revisions would still require the core libraries for all platforms.
+// CHECK-LABEL: @lower_while_ascii
+// CHECK: [[A:%[0-9]]] = load <16 x i8>
+// CHECK-NEXT: [[B:%[0-9]]] = icmp slt <16 x i8> [[A]], zeroinitializer
+// CHECK-NEXT: [[C:%[0-9]]] = bitcast <16 x i1> [[B]] to i16
+#[no_mangle]
+pub fn lower_while_ascii(s: &str) -> (alloc::string::String, &str) {
+    alloc::str::convert_while_ascii(s, u8::to_ascii_lowercase)
+}