diff options
| author | bors <bors@rust-lang.org> | 2024-05-03 17:41:48 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2024-05-03 17:41:48 +0000 |
| commit | efa15ebfef7d1ee26bb54b3737653227870c68c1 (patch) | |
| tree | e49126e08947f875eebf3bab93c7906c824d7181 /tests/codegen/patchable-function-entry | |
| parent | 7ed351a5083286afe1acf0681046b092e79fa91b (diff) | |
| parent | 2d082aedf73cfa457c726716829871820c9bb9d9 (diff) | |
| download | rust-efa15ebfef7d1ee26bb54b3737653227870c68c1.tar.gz rust-efa15ebfef7d1ee26bb54b3737653227870c68c1.zip | |
Auto merge of #123441 - saethlin:fixed-len-file-names, r=oli-obk
Stabilize the size of incr comp object file names The current implementation does not produce stable-length paths, and we create the paths in a way that makes our allocation behavior is nondeterministic. I think `@eddyb` fixed a number of other cases like this in the past, and this PR fixes another one. Whether that actually matters I have no idea, but we still have bimodal behavior in rustc-perf and the non-uniformity in `find` and `ls` was bothering me. I've also removed the truncation of the mangled CGU names. Before this PR incr comp paths look like this: ``` target/debug/incremental/scratch-38izrrq90cex7/s-gux6gz0ow8-1ph76gg-ewe1xj434l26w9up5bedsojpd/261xgo1oqnd90ry5.o ``` And after, they look like this: ``` target/debug/incremental/scratch-035omutqbfkbw/s-gux6borni0-16r3v1j-6n64tmwqzchtgqzwwim5amuga/55v2re42sztc8je9bva6g8ft3.o ``` On the one hand, I'm sure this will break some people's builds because they're on Windows and only a few bytes from the path length limit. But if we're that seriously worried about the length of our file names, I have some other ideas on how to make them smaller. And last time I deleted some hash truncations from the compiler, there was a huge drop in the number if incremental compilation ICEs that were reported: https://github.com/rust-lang/rust/pull/110367https://github.com/rust-lang/rust/pull/110367 --- Upon further reading, this PR actually fixes a bug. This comment says the CGU names are supposed to be a fixed-length hash, and before this PR they aren't: https://github.com/rust-lang/rust/blob/ca7d34efa94afe271accf2bd3d44152a5bd6fff1/compiler/rustc_monomorphize/src/partitioning.rs#L445-L448
Diffstat (limited to 'tests/codegen/patchable-function-entry')
0 files changed, 0 insertions, 0 deletions
