about summary refs log tree commit diff
path: root/tests/codegen/src-hash-algorithm/src-hash-algorithm-md5.rs
diff options
context:
space:
mode:
authorChris Denton <chris@chrisdenton.dev>2025-04-22 15:24:05 +0000
committerGitHub <noreply@github.com>2025-04-22 15:24:05 +0000
commit8089e317b55841af5e9f3d08952e44ce01853c26 (patch)
tree8821f52b305cab85509992bb62ca664dc24ab97f /tests/codegen/src-hash-algorithm/src-hash-algorithm-md5.rs
parent1586660fb270fcf32a77521b7348ac138c99c489 (diff)
parentb5e8f1f0cec8065eb9cb453ad4c5aa5bec8baf32 (diff)
downloadrust-8089e317b55841af5e9f3d08952e44ce01853c26.tar.gz
rust-8089e317b55841af5e9f3d08952e44ce01853c26.zip
Rollup merge of #139921 - Kivooeo:master, r=WaffleLapkin
improve diagnostic for raw pointer field access with ->

This PR enhances the error messages emitted by the Rust compiler when users attempt to use the `->` operator for field access on raw pointers or when dereferencing is needed. The changes aim to provide clearer guidance, by suggesting the correct use of the `.` operator and explicit dereferencing.

**Before:**
```
help: `xs` is a raw pointer; try dereferencing it
   |
LL |         (*xs)->count += 1;
   |         ++  +
```

**Now:**
```
help: use `.` on a dereferenced raw pointer instead
   |
LL -         xs->count += 1;
LL +         (*xs).count += 1;
   |
```

I added extra clarification in the message. Since this error occurs in the parser, we can't be certain that the type is a raw pointer. That's why the message includes only a small note in brackets. (In contrast, the message above is emitted in HIR, where we *can* check whether it's a raw pointer.)

**Before:**
```
  --> main.rs:11:11
   |
11 |         xs->count += 1;
   |           ^^
   |
   = help: the . operator will dereference the value if needed
```
**After:**
```
--> main.rs:11:11
   |
11 |         xs->count += 1;
   |           ^^
   |
   = help: the `.` operator will automatically dereference the value, except if the value is a raw pointer
```
Diffstat (limited to 'tests/codegen/src-hash-algorithm/src-hash-algorithm-md5.rs')
0 files changed, 0 insertions, 0 deletions